src/accessors.cc - Issue 183683022: Enable Object.observe by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/accessors.cc

Issue 183683022: Enable Object.observe by default (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/accessors.cc

diff --git a/src/accessors.cc b/src/accessors.cc

index 47b0a856332e24cec0b4ff7e8ab0666d20ca9dc2..8b3ff705c2fa553e49f24f5afb283894d3a7dfea 100644

--- a/src/accessors.cc

+++ b/src/accessors.cc

@@ -621,7 +621,6 @@ MaybeObject* Accessors::FunctionSetPrototype(Isolate* isolate,

Handle<Object> old_value;

bool is_observed =

rossberg 2014/03/06 08:41:35 Nit: does this fit one line now?

rafaelw 2014/03/07 04:33:06 Yes. done On 2014/03/06 08:41:35, rossberg wrote:

- FLAG_harmony_observation &&

*function == *object &&

function->map()->is_observed();

if (is_observed) {

« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | src/ic.cc » ('J')