Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183683012: Oilpan: Use the OilpanExpectations for oilpan specific test expectations. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, oilpan-reviews
Visibility:
Public.

Description

Oilpan: Use the OilpanExpectations for oilpan specific test expectations. R=erik.corry@gmail.com, haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168366

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M LayoutTests/OilpanExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-03 10:45:33 UTC) #1
Mads Ager (chromium)
6 years, 9 months ago (2014-03-03 10:45:56 UTC) #2
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-03 10:48:59 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-03 10:52:25 UTC) #4
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-03 10:56:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/183683012/20001
6 years, 9 months ago (2014-03-03 10:56:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 13:58:47 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24503
6 years, 9 months ago (2014-03-03 13:58:48 UTC) #8
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-03 14:00:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/183683012/20001
6 years, 9 months ago (2014-03-03 14:01:04 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 19:56:20 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24758
6 years, 9 months ago (2014-03-03 19:56:20 UTC) #12
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 06:48:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/183683012/20001
6 years, 9 months ago (2014-03-04 06:48:40 UTC) #14
commit-bot: I haz the power
Change committed as 168366
6 years, 9 months ago (2014-03-04 06:49:26 UTC) #15
Mads Ager (chromium)
6 years, 9 months ago (2014-03-04 11:00:24 UTC) #16
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/186403004/ by ager@chromium.org.

The reason for reverting is: Only the release oilpan layout tests are run with
the --additional-expectations flag. Reverting back to using TestExpectations for
now..

Powered by Google App Engine
This is Rietveld 408576698