Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 183683007: Trace base class Event in SpeechRecognitionError. (Closed)

Created:
6 years, 9 months ago by zerny-chromium
Modified:
6 years, 9 months ago
Reviewers:
haraken, sof
CC:
blink-reviews, oilpan-reviews
Visibility:
Public.

Description

Trace base class Event in SpeechRecognitionError. R=sigbjornf@opera.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/modules/speech/SpeechRecognitionError.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
zerny-chromium
Found by the clang plugin.
6 years, 9 months ago (2014-02-28 13:25:08 UTC) #1
haraken
LGTM, thanks!
6 years, 9 months ago (2014-02-28 13:25:36 UTC) #2
haraken
On 2014/02/28 13:25:36, haraken wrote: > LGTM, thanks! hmm, I think this is already fixed ...
6 years, 9 months ago (2014-02-28 13:26:34 UTC) #3
zerny-chromium
On 2014/02/28 13:26:34, haraken wrote: > On 2014/02/28 13:25:36, haraken wrote: > > LGTM, thanks! ...
6 years, 9 months ago (2014-02-28 13:30:03 UTC) #4
haraken
> > hmm, I think this is already fixed in > > https://codereview.chromium.org/182763002/. > > ...
6 years, 9 months ago (2014-02-28 13:30:49 UTC) #5
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-02-28 13:31:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/183683007/1
6 years, 9 months ago (2014-02-28 13:31:12 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 14:54:38 UTC) #8
Message was sent while issue was closed.
Change committed as 168133

Powered by Google App Engine
This is Rietveld 408576698