Issue 18368002: MIPS: Fix register usage in ProfileEntryHookStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18368002: MIPS: Fix register usage in ProfileEntryHookStub (Closed)

Created:
7 years, 5 months ago by kilvadyb

Modified:
7 years, 5 months ago

Reviewers:
kisg, Paul Lind, palfia, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix register usage in ProfileEntryHookStub Different register must be used to pass the test on target hardware. BUG= TEST=cctest/test-api/SetFunctionEntryHook

Patch Set 2 : Fixed nit. #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View	1	3 chunks	+10 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kisg

LGTM with one nit https://codereview.chromium.org/18368002/diff/3001/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/18368002/diff/3001/src/mips/code-stubs-mips.cc#newcode7533 src/mips/code-stubs-mips.cc:7533: // This should contain all ...

7 years, 5 months ago (2013-07-01 20:48:22 UTC) #2

Fixed nit and committed as r15432.

Expand Messages | Collapse Messages

Issue 18368002: MIPS: Fix register usage in ProfileEntryHookStub (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed nit. #

Messages