Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1836793002: [ios] Moved WebLoadParams inside NavigationManager. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, grt+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, plaree+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, dhollowa+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Moved WebLoadParams inside NavigationManager. This matches content's NavigationController::LoadURLParams placement. After the change navigation_manager.h is now an Objective-C header and should be imported instead of included. BUG=597990 Committed: https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420 Cr-Commit-Position: refs/heads/master@{#383524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -110 lines) Patch
M ios/chrome/browser/interstitials/ios_chrome_controller_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/safe_browsing/safe_browsing_blocking_page.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/safe_browsing/ui_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/search/search_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ssl/ios_chrome_security_state_model_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +28 lines, -0 lines 0 comments Download
M ios/web/navigation/web_load_params.h View 1 chunk +4 lines, -41 lines 0 comments Download
D ios/web/navigation/web_load_params.mm View 1 chunk +0 lines, -39 lines 0 comments Download
M ios/web/public/navigation_manager.h View 2 chunks +40 lines, -0 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ios/web/shell/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/shell/view_controller.mm View 5 chunks +12 lines, -9 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 4 chunks +5 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836793002/1
4 years, 9 months ago (2016-03-26 20:50:34 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-26 21:27:28 UTC) #4
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-03-28 16:14:49 UTC) #6
marq (ping after 24h)
lgtm
4 years, 8 months ago (2016-03-28 17:43:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836793002/1
4 years, 8 months ago (2016-03-28 17:53:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 18:27:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:29:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e36b109e26e52520d7805136ca3d20d2eea05420
Cr-Commit-Position: refs/heads/master@{#383524}

Powered by Google App Engine
This is Rietveld 408576698