DescriptionRevert of Refine ash shelf tooltip closing on non-mash ChromeOS. (patchset #4 id:60001 of https://codereview.chromium.org/1828133004/ )
Reason for revert:
Memory failures, eg.
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/8340
Original issue's description:
> Refine ash shelf tooltip closing on non-mash ChromeOS.
>
> Fixes a regression from: https://codereview.chromium.org/1816753002
> Also reverse expected behavior for touching tooltips.
> (closes on stable, tests expected them to stay open...)
>
> Inline bubble function definitions.
> Call WillDeleteShelf earlier to fix a test crash...
> TODO: Encapsulate more ShelfLayoutManager code.
>
> BUG=595853
> TEST=ChromeOS tooltips stay open on hover; close for external touches.
> R=sky@chromium.org
>
> Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24
> Cr-Commit-Position: refs/heads/master@{#383404}
TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595853
Committed: https://crrev.com/053ef0ef0cb9765594615de430fad25b24d100c6
Cr-Commit-Position: refs/heads/master@{#383444}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|