Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1836753002: Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (Closed)

Created:
4 years, 9 months ago by msw
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (patchset #4 id:60001 of https://codereview.chromium.org/1828133004/ ) Reason for revert: Memory failures, eg. https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/8340 Original issue's description: > Refine ash shelf tooltip closing on non-mash ChromeOS. > > Fixes a regression from: https://codereview.chromium.org/1816753002 > Also reverse expected behavior for touching tooltips. > (closes on stable, tests expected them to stay open...) > > Inline bubble function definitions. > Call WillDeleteShelf earlier to fix a test crash... > TODO: Encapsulate more ShelfLayoutManager code. > > BUG=595853 > TEST=ChromeOS tooltips stay open on hover; close for external touches. > R=sky@chromium.org > > Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 > Cr-Commit-Position: refs/heads/master@{#383404} TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595853 Committed: https://crrev.com/053ef0ef0cb9765594615de430fad25b24d100c6 Cr-Commit-Position: refs/heads/master@{#383444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -86 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 5 chunks +60 lines, -56 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 chunk +23 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
msw
Created Revert of Refine ash shelf tooltip closing on non-mash ChromeOS.
4 years, 9 months ago (2016-03-26 04:18:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836753002/1
4 years, 9 months ago (2016-03-26 04:18:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-26 04:19:05 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 04:20:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/053ef0ef0cb9765594615de430fad25b24d100c6
Cr-Commit-Position: refs/heads/master@{#383444}

Powered by Google App Engine
This is Rietveld 408576698