Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Issue 1836713002: [libfuzzer] registering ubsan build. (Closed)

Created:
4 years, 9 months ago by aizatsky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[libfuzzer] registering ubsan build. BUG=596650, 598097 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299499

Patch Set 1 #

Patch Set 2 : added slaves.cfg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M masters/master.chromium.fyi/master.cfg View 3 chunks +10 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
aizatsky
I forgot to register the build in master config.
4 years, 9 months ago (2016-03-25 23:55:47 UTC) #3
Vadim Sh.
lgtm
4 years, 9 months ago (2016-03-25 23:58:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836713002/1
4 years, 9 months ago (2016-03-25 23:59:20 UTC) #7
Vadim Sh.
wait, not lgtm you need it to assign to a slave too, see https://chromium.googlesource.com/chromium/tools/build/+/master/masters/master.chromium.fyi/slaves.cfg
4 years, 9 months ago (2016-03-25 23:59:37 UTC) #8
aizatsky
Added it to slaves.cfg... So many files to change to add a build.... PTAL. PS ...
4 years, 9 months ago (2016-03-26 00:02:03 UTC) #11
inferno
lgtm
4 years, 9 months ago (2016-03-26 00:03:06 UTC) #13
inferno
On 2016/03/26 00:03:06, inferno wrote: > lgtm We should keep an eye if the builder ...
4 years, 9 months ago (2016-03-26 00:03:42 UTC) #15
Vadim Sh.
lgtm yes, adding builders is PITA unfortunately :(
4 years, 9 months ago (2016-03-26 00:04:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836713002/20001
4 years, 9 months ago (2016-03-26 00:04:38 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299499
4 years, 9 months ago (2016-03-26 00:08:15 UTC) #20
Dirk Pranke
4 years, 9 months ago (2016-03-26 00:09:52 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698