Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 183663033: Pre-bind the 'xml' prefix for serialization of XML fragments (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews
Visibility:
Public.

Description

Pre-bind the 'xml' prefix for serialization of XML fragments The Namespaces in XML spec states: "The prefix xml is by definition bound to the namespace name http://www.w3.org/XML/1998/namespace." BUG=340794 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A LayoutTests/fast/dom/XMLSerializer-prebound-xml-prefix.html View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 9 months ago (2014-03-06 13:33:52 UTC) #1
adamk
lgtm I'm surprised we don't have any other tests that notice this difference.
6 years, 9 months ago (2014-03-06 19:25:48 UTC) #2
fs
On 2014/03/06 19:25:48, adamk wrote: > lgtm > > I'm surprised we don't have any ...
6 years, 9 months ago (2014-03-06 19:29:04 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-03-06 19:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/183663033/1
6 years, 9 months ago (2014-03-06 19:30:05 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 20:11:38 UTC) #6
Message was sent while issue was closed.
Change committed as 168673

Powered by Google App Engine
This is Rietveld 408576698