Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 183663025: Implement SharedWorkerServiceImpl::TerminateWorker(). (Closed)

Created:
6 years, 9 months ago by horo
Modified:
6 years, 9 months ago
Reviewers:
kinuko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Implement SharedWorkerServiceImpl::TerminateWorker(). This will be called when the user clicks "terminate" in chrome://inspect/#workers BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M content/browser/shared_worker/shared_worker_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
horo
kinuko@ Could you please review?
6 years, 9 months ago (2014-03-05 07:28:52 UTC) #1
kinuko
lgtm
6 years, 9 months ago (2014-03-05 08:08:52 UTC) #2
horo
The CQ bit was checked by horo@chromium.org
6 years, 9 months ago (2014-03-05 08:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/183663025/1
6 years, 9 months ago (2014-03-05 08:11:22 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 12:05:12 UTC) #5
Message was sent while issue was closed.
Change committed as 255017

Powered by Google App Engine
This is Rietveld 408576698