Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 183663021: Notification.permission's default value of "default" should be testable. (Closed)

Created:
6 years, 9 months ago by Peter Beverloo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Notification.permission's default value of "default" should be testable. If no permission request has been answered yet, the Notification.permission string of the Web Notification API should be set to "default". The presenter used for testing can currently only return "allowed" or "denied". BUG=349015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256273

Patch Set 1 #

Patch Set 2 : s/KnownNotificationMap/KnownOriginMap/ #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M content/shell/renderer/test_runner/TestRunner.cpp View 1 chunk +8 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Peter Beverloo
This is to support "notifications-permission-values.html" of the new tests: https://codereview.chromium.org/186713002 It's backwards compatible with the ...
6 years, 9 months ago (2014-03-04 15:39:43 UTC) #1
Andrew T Wilson (Slow)
lgtm
6 years, 9 months ago (2014-03-04 21:54:24 UTC) #2
pfeldman
rslgtm
6 years, 9 months ago (2014-03-05 15:14:57 UTC) #3
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-05 15:26:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/183663021/20001
6 years, 9 months ago (2014-03-05 15:26:47 UTC) #5
Peter Beverloo
The CQ bit was unchecked by peter@chromium.org
6 years, 9 months ago (2014-03-05 15:40:12 UTC) #6
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 9 months ago (2014-03-11 14:20:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/183663021/40001
6 years, 9 months ago (2014-03-11 14:20:48 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 17:56:59 UTC) #9
Message was sent while issue was closed.
Change committed as 256273

Powered by Google App Engine
This is Rietveld 408576698