Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: gpu/command_buffer/service/common_decoder.cc

Issue 1836603002: gpu: Pull some variables onto the stack in the decoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/common_decoder.cc
diff --git a/gpu/command_buffer/service/common_decoder.cc b/gpu/command_buffer/service/common_decoder.cc
index a15c496ddbc02aff45d906123df00dc6595d88a7..69e028694e5b2e034415143f64daf8b338d09c2f 100644
--- a/gpu/command_buffer/service/common_decoder.cc
+++ b/gpu/command_buffer/service/common_decoder.cc
@@ -282,7 +282,7 @@ error::Error CommonDecoder::HandleGetBucketStart(uint32_t immediate_data_size,
uint8_t* data = NULL;
if (data_memory_size != 0 || data_memory_id != 0 || data_memory_offset != 0) {
data = GetSharedMemoryAs<uint8_t*>(
- args.data_memory_id, args.data_memory_offset, args.data_memory_size);
+ args.data_memory_id, args.data_memory_offset, data_memory_size);
piman 2016/03/25 20:48:06 nit: same with other arguments - let's make sure t
if (!data) {
return error::kInvalidArguments;
}
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698