Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1836603002: gpu: Pull some variables onto the stack in the decoder (Closed)

Created:
4 years, 9 months ago by no sievers
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Pull some variables onto the stack in the decoder CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel BUG=597636, 597625 Committed: https://crrev.com/ff5407f8d6d71116e01d6ea18db75a4f8d1e0692 Cr-Commit-Position: refs/heads/master@{#383379}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M gpu/command_buffer/service/common_decoder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 8 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
piman
https://codereview.chromium.org/1836603002/diff/1/gpu/command_buffer/service/common_decoder.cc File gpu/command_buffer/service/common_decoder.cc (right): https://codereview.chromium.org/1836603002/diff/1/gpu/command_buffer/service/common_decoder.cc#newcode285 gpu/command_buffer/service/common_decoder.cc:285: args.data_memory_id, args.data_memory_offset, data_memory_size); nit: same with other arguments - ...
4 years, 9 months ago (2016-03-25 20:48:06 UTC) #4
piman
LGTM after nit
4 years, 9 months ago (2016-03-25 20:49:04 UTC) #5
piman
lgtm
4 years, 9 months ago (2016-03-25 20:51:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836603002/20001
4 years, 9 months ago (2016-03-25 20:51:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 22:08:05 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 22:09:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff5407f8d6d71116e01d6ea18db75a4f8d1e0692
Cr-Commit-Position: refs/heads/master@{#383379}

Powered by Google App Engine
This is Rietveld 408576698