Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1836583002: [MD settings] match downloads path to mocks (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] match downloads path to mocks This CL changes the downloads input into a secondary label and adds the secondary action class to the change button. BUG=597883 Committed: https://crrev.com/7e3a03855688b46f3abad63dc94093b09e5a6f4b Cr-Commit-Position: refs/heads/master@{#383364}

Patch Set 1 : touchups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dschuyler
4 years, 9 months ago (2016-03-25 20:34:28 UTC) #3
dpapad
lgtm
4 years, 9 months ago (2016-03-25 20:38:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836583002/20001
4 years, 9 months ago (2016-03-25 20:48:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-25 21:26:52 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:28:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e3a03855688b46f3abad63dc94093b09e5a6f4b
Cr-Commit-Position: refs/heads/master@{#383364}

Powered by Google App Engine
This is Rietveld 408576698