Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1836563002: Revert of Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU bu… (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
Reviewers:
cblume, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU bu… (patchset #1 id:1 of https://codereview.chromium.org/1835003002/ ) Reason for revert: Speculative - seems likely to be the results of nanobench crashes on several bots. Original issue's description: > Re-enable CPU mipmap generation for Ganesh. Aniso mips were landed a while ago. However, the CPU builder fails when it sees Index8 (among other things), so change the code to fallback to GPU in that case. Additionally, if we're going to be mipping an sRGB image, don't use the CPU code (which is not yet gamma correct). Unfortunately, this means that we will often be using the GPU path, still - with recent codec changes, most images are coming in tagged as sRGB. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1835003002 > > Committed: https://skia.googlesource.com/skia/+/b0ac1af7fab467aacbc27d20d14a09bcb960472f TBR=reed@google.com,bsalomon@google.com,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b3c9e4faaaea99ca8c428f0cadc2945c330f1461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M src/core/SkImageCacherator.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrImageIDTextureAdjuster.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Brian Osman
4 years, 9 months ago (2016-03-25 18:54:13 UTC) #1
Created Revert of Re-enable CPU mipmap generation for Ganesh. Aniso mips were
landed a while ago. However, the CPU bu…

Powered by Google App Engine
This is Rietveld 408576698