Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 1836543002: [ios] Removed RequestTracker dependency from WebLoadParams. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed RequestTracker dependency from WebLoadParams. WKWebView does not allow controlling the cache so cache_mode load param is not used. BUG=597990 Committed: https://crrev.com/2aca722505ea2a9a2fce3372978e210013e7c946 Cr-Commit-Position: refs/heads/master@{#383452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -63 lines) Patch
M ios/web/navigation/web_load_params.h View 2 chunks +4 lines, -9 lines 0 comments Download
M ios/web/navigation/web_load_params.mm View 3 chunks +0 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 6 chunks +1 line, -33 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836543002/1
4 years, 9 months ago (2016-03-25 18:03:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 18:44:52 UTC) #5
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-26 03:38:26 UTC) #7
marq (ping after 24h)
lgtm
4 years, 9 months ago (2016-03-26 09:11:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836543002/1
4 years, 9 months ago (2016-03-26 09:11:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-26 09:15:48 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 09:18:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2aca722505ea2a9a2fce3372978e210013e7c946
Cr-Commit-Position: refs/heads/master@{#383452}

Powered by Google App Engine
This is Rietveld 408576698