Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Issue 1836533002: Revert of Content "gn check" work. (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
jschuh, jam, dcheng
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, piman+watch_chromium.org, sadrul, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Content "gn check" work. (patchset #10 id:180001 of https://codereview.chromium.org/1828483002/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19740/steps/compile/logs/stdio Original issue's description: > Content "gn check" work. > > Make content/gpu and content/plugin pass GN check. > > Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve. > > The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn > > Renames the ui/events/ipc according to GN style > > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > TBR=jschuh (IPC build tweak) > > Committed: https://crrev.com/f510be61306f5e4986eceb1f8686bfcc934cd400 > Cr-Commit-Position: refs/heads/master@{#383208} TBR=jam@chromium.org,jschuh@chromium.org,dcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/fc09b679eaa615029a0288fc202c7886aa49e278 Cr-Commit-Position: refs/heads/master@{#383289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -281 lines) Patch
M .gn View 1 chunk +0 lines, -13 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M content/app/BUILD.gn View 1 chunk +1 line, -14 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +1 line, -14 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +3 lines, -12 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 3 chunks +0 lines, -10 lines 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/gpu/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/plugin/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -14 lines 0 comments Download
M content/shell/BUILD.gn View 5 chunks +2 lines, -12 lines 0 comments Download
M content/test/BUILD.gn View 31 chunks +9 lines, -127 lines 0 comments Download
M content/utility/BUILD.gn View 3 chunks +2 lines, -17 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ipc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
Created Revert of Content "gn check" work.
4 years, 9 months ago (2016-03-25 16:55:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836533002/1
4 years, 9 months ago (2016-03-25 16:55:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 16:57:27 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:58:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc09b679eaa615029a0288fc202c7886aa49e278
Cr-Commit-Position: refs/heads/master@{#383289}

Powered by Google App Engine
This is Rietveld 408576698