Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 183653002: Fix braille backtranslation size limit. (Closed)

Created:
6 years, 9 months ago by Peter Lundblad
Modified:
6 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Fix braille backtranslation size limit. Sometimes, a contracted string results in more than twice the size of the input being the result of back translation. This is especially true for small strings (e.g. a single letter k translating to knowledgable). This CL uses a similar approach as https://codereview.chromium.org/124403002 expanding the allocated buffer, working around liblouis api quirks. BUG=310285 R=dtseng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254023

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M chrome/test/data/chromeos/liblouis_nacl/test.js View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc View 1 chunk +31 lines, -9 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Peter Lundblad
6 years, 9 months ago (2014-02-27 18:56:19 UTC) #1
David Tseng
https://codereview.chromium.org/183653002/diff/1/third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc File third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc (right): https://codereview.chromium.org/183653002/diff/1/third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc#newcode226 third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc:226: // and we have to retry with a larger ...
6 years, 9 months ago (2014-02-27 22:05:06 UTC) #2
David Tseng
LGTM
6 years, 9 months ago (2014-02-27 22:07:04 UTC) #3
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 9 months ago (2014-02-27 23:00:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/183653002/1
6 years, 9 months ago (2014-02-27 23:04:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/183653002/1
6 years, 9 months ago (2014-02-28 01:11:51 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 02:20:59 UTC) #7
Message was sent while issue was closed.
Change committed as 254023

Powered by Google App Engine
This is Rietveld 408576698