Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1836493002: Rename encoders to Sk*ImageEncoder (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename encoders to Sk*ImageEncoder BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1836493002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/c1d0312b227328bee7240d1df4ceee55cf6e1858

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2259 lines) Patch
M cmake/CMakeLists.txt View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/images.gyp View 1 3 chunks +17 lines, -17 lines 0 comments Download
M public.bzl View 1 2 3 4 chunks +3 lines, -8 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/codec/SkJpegDecoderMgr.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/codec/SkJpegDecoderMgr.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A + src/codec/SkJpegUtility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/codec/SkJpegUtility.cpp View 1 chunk +2 lines, -1 line 0 comments Download
D src/codec/SkJpegUtility_codec.h View 1 chunk +0 lines, -50 lines 0 comments Download
D src/codec/SkJpegUtility_codec.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
A + src/images/SkARGBImageEncoder.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/images/SkForceLinking.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/images/SkGIFMovie.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/images/SkImageDecoder_FactoryDefault.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D src/images/SkImageDecoder_ktx.cpp View 1 chunk +0 lines, -97 lines 0 comments Download
D src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +0 lines, -282 lines 0 comments Download
D src/images/SkImageDecoder_libpng.cpp View 1 chunk +0 lines, -344 lines 0 comments Download
D src/images/SkImageDecoder_libwebp.cpp View 1 chunk +0 lines, -247 lines 0 comments Download
D src/images/SkImageEncoder_argb.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
A + src/images/SkJPEGImageEncoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
A + src/images/SkJPEGWriteUtility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/images/SkJPEGWriteUtility.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/images/SkJpegUtility.h View 1 chunk +0 lines, -47 lines 0 comments Download
D src/images/SkJpegUtility.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
A + src/images/SkKTXImageEncoder.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/images/SkMovie_FactoryDefault.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/images/SkMovie_gif.cpp View 1 chunk +0 lines, -452 lines 0 comments Download
A + src/images/SkPNGImageEncoder.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/images/SkWEBPImageEncoder.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/ports/SkImageDecoder_CG.cpp View 1 chunk +0 lines, -162 lines 0 comments Download
D src/ports/SkImageDecoder_WIC.cpp View 1 chunk +0 lines, -246 lines 0 comments Download
A + src/ports/SkImageEncoder_CG.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/ports/SkImageEncoder_WIC.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/ports/SkImageEncoder_none.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836493002/1
4 years, 9 months ago (2016-03-25 13:19:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/7450)
4 years, 9 months ago (2016-03-25 13:23:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836493002/20001
4 years, 9 months ago (2016-03-25 13:29:34 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-CMake-Trybot/builds/45)
4 years, 9 months ago (2016-03-25 13:33:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836493002/40001
4 years, 9 months ago (2016-03-25 13:36:20 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 13:46:30 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836493002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836493002/60001
4 years, 9 months ago (2016-03-25 13:47:29 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 14:09:51 UTC) #17
msarett
Passes Google3 presubmit https://codereview.chromium.org/1836493002/diff/1/src/ports/SkImageEncoder_none.cpp File src/ports/SkImageEncoder_none.cpp (right): https://codereview.chromium.org/1836493002/diff/1/src/ports/SkImageEncoder_none.cpp#newcode3 src/ports/SkImageEncoder_none.cpp:3: * Copyright 2006 The Android Open ...
4 years, 9 months ago (2016-03-25 14:19:18 UTC) #19
scroggo
lgtm
4 years, 9 months ago (2016-03-25 15:54:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836493002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836493002/60001
4 years, 9 months ago (2016-03-25 15:57:30 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 15:58:59 UTC) #24
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c1d0312b227328bee7240d1df4ceee55cf6e1858

Powered by Google App Engine
This is Rietveld 408576698