Fix up and rename VisibleMargins() in preparation for making use of it.

ui/gfx/image/image_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/image/image_util.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 
 #include "base/memory/scoped_ptr.h"
 #include "build/build_config.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/jpeg_codec.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 
+namespace {
+
+// Returns whether column |x| of |bitmap| has any pixels with opacity > min,

[danakj, 2016/03/25 23:35:28]

min looks like it's hardcoded, maybe it was a param before? update the comment?

[Peter Kasting, 2016/03/26 01:01:57]

I actually wrote the comment to describe this hardcoded behavior, so it sounds
like I didn't write a good enough comment.  I'll try harder.

(Also, spelling.)

+// where min is a small number representing "pretty much trasparent".
+bool ColumnHasVisiblePixels(const SkBitmap& bitmap, int x) {
+  const SkAlpha kMinimumVisibleOpacity = 12;
+  for (int y = 0; y < bitmap.height(); ++y) {
+    if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity)
+      return true;
+  }
+  return false;
+}
+
+}  // namespace
+
 namespace gfx {
 
-const uint32_t kMinimumVisibleOpacity = 12;
-
 // The iOS implementations of the JPEG functions are in image_util_ios.mm.
 #if !defined(OS_IOS)
 Image ImageFrom1xJPEGEncodedData(const unsigned char* input,
                                  size_t input_size) {
   scoped_ptr<SkBitmap> bitmap(gfx::JPEGCodec::Decode(input, input_size));
   if (bitmap.get())
     return Image::CreateFrom1xBitmap(*bitmap);
 
   return Image();
 }
@@ skipping 13 matching lines @@
 
   return gfx::JPEGCodec::Encode(
           reinterpret_cast<unsigned char*>(bitmap.getAddr32(0, 0)),
           gfx::JPEGCodec::FORMAT_SkBitmap, bitmap.width(),
           bitmap.height(),
           static_cast<int>(bitmap.rowBytes()), quality,
           dst);
 }
 #endif  // !defined(OS_IOS)
 
-bool VisibleMargins(const ImageSkia& image, int* leading, int* trailing) {
-  *leading = 0;
-  *trailing = std::max(1, image.width()) - 1;
-  if (!image.HasRepresentation(1.0))
-    return false;
+void GetVisibleMargins(const ImageSkia& image, int* left, int* right) {
+  *left = 0;
+  *right = 0;
+  const SkBitmap& bitmap = image.GetRepresentation(1.0).sk_bitmap();
+  if (bitmap.drawsNothing() || bitmap.isOpaque())
+    return;
 
-  const ImageSkiaRep& rep = image.GetRepresentation(1.0);
-  if (rep.is_null())
-    return false;
+  SkAutoLockPixels lock(bitmap);
+  int x = 0;
+  for (; x < bitmap.width(); ++x) {
+    if (ColumnHasVisiblePixels(bitmap, x)) {
+      *left = x;
+      break;
+    }
+  }
 
-  const SkBitmap& bitmap = rep.sk_bitmap();
-  if (bitmap.isNull() || bitmap.width() == 0)
-    return false;
+  if (x == bitmap.width()) {
+    // Image is fully transparent.  Divide the width in half, giving the leading
+    // region the extra pixel for odd widths.
+    *left = (bitmap.width() + 1) / 2;
+    *right = bitmap.width() - *left;
+    return;
+  }
 
-  if (bitmap.isOpaque())
-    return true;
-
-  SkAutoLockPixels l(bitmap);
-  int inner_min = bitmap.width();
-  for (int x = 0; x < bitmap.width(); ++x) {
-    for (int y = 0; y < bitmap.height(); ++y) {
-      if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) {
-        inner_min = x;
-        break;
-      }
-    }
-    if (inner_min < bitmap.width())
+  // Since we already know column *leading is non-transparent, we can avoid

[danakj, 2016/03/25 23:35:28]

leading->left ?

[Peter Kasting, 2016/03/26 01:01:57]

Yeah, oops.

+  // rechecking that column; hence the '>' here.
+  for (x = bitmap.width() - 1; x > *left; --x) {
+    if (ColumnHasVisiblePixels(bitmap, x))
       break;
   }
-
-  int inner_max = -1;
-  for (int x = bitmap.width() - 1; x > inner_min; --x) {
-    for (int y = 0; y < bitmap.height(); ++y) {
-      if (SkColorGetA(bitmap.getColor(x, y)) > kMinimumVisibleOpacity) {
-        inner_max = x;
-        break;
-      }
-    }
-    if (inner_max > -1)
-      break;
-  }
-
-  if (inner_min == bitmap.width()) {
-    *leading = bitmap.width()/2;
-    *trailing = bitmap.width()/2 + 1;
-    return true;
-  }
-
-  *leading = inner_min;
-  *trailing = inner_max;
-  return true;
+  *right = bitmap.width() - 1 - x;
 }
 
 }  // namespace gfx