Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1836443003: add SK_SUPPORT_LEGACY_IMAGEFILTER_PTR flag for future skia CL (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
f(malita), reed2, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add SK_SUPPORT_LEGACY_IMAGEFILTER_PTR flag for future skia CL Guard for upcoming swap of Skia's ImageFilter factories over to smart pointers. Committed: https://crrev.com/d7b107cbc87b66498f14025aa67e3c4cecf0c812 Cr-Commit-Position: refs/heads/master@{#383338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
robertphillips
4 years, 9 months ago (2016-03-25 18:50:05 UTC) #3
f(malita)
lgtm
4 years, 9 months ago (2016-03-25 18:52:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836443003/1
4 years, 9 months ago (2016-03-25 18:52:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 20:11:23 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 20:12:21 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d7b107cbc87b66498f14025aa67e3c4cecf0c812
Cr-Commit-Position: refs/heads/master@{#383338}

Powered by Google App Engine
This is Rietveld 408576698