Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: pdfium.gyp

Issue 1836443002: Re-enable warning 4005 and remove _CRT_SECURE_NO_WARNINGS (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fxcrt/include/fx_system.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 PDFium Authors. All rights reserved. 1 # Copyright 2015 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # TODO(thakis): Enable this, pdfium:29 7 # TODO(thakis): Enable this, pdfium:29
8 #'chromium_code': 1, 8 #'chromium_code': 1,
9 9
10 'variables': { 10 'variables': {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' , 50 '-Xclang -add-plugin -Xclang find-bad-constructs <(clang_plugin_args)' ,
51 }], 51 }],
52 ], 52 ],
53 }, 53 },
54 'target_defaults': { 54 'target_defaults': {
55 'defines' : [ 55 'defines' : [
56 'OPJ_STATIC', 56 'OPJ_STATIC',
57 'PNG_PREFIX', 57 'PNG_PREFIX',
58 'PNG_USE_READ_MACROS', 58 'PNG_USE_READ_MACROS',
59 'V8_DEPRECATION_WARNINGS', 59 'V8_DEPRECATION_WARNINGS',
60 '_CRT_SECURE_NO_WARNINGS',
61 ], 60 ],
62 'include_dirs': [ 61 'include_dirs': [
63 # This is implicit in GN. 62 # This is implicit in GN.
64 '<(DEPTH)', 63 '<(DEPTH)',
65 '.', 64 '.',
66 'third_party/freetype/include', 65 'third_party/freetype/include',
67 'third_party/freetype/include/freetype', 66 'third_party/freetype/include/freetype',
68 ], 67 ],
69 'conditions': [ 68 'conditions': [
70 ['pdf_use_skia==1', { 69 ['pdf_use_skia==1', {
(...skipping 16 matching lines...) Expand all
87 }], 86 }],
88 ], 87 ],
89 }], 88 }],
90 ['clang==1 and clang_use_pdfium_plugins==1', { 89 ['clang==1 and clang_use_pdfium_plugins==1', {
91 'cflags': [ 90 'cflags': [
92 '<@(clang_pdfium_plugins_flags)', 91 '<@(clang_pdfium_plugins_flags)',
93 ], 92 ],
94 }], 93 }],
95 ], 94 ],
96 'msvs_disabled_warnings': [ 95 'msvs_disabled_warnings': [
97 4005, 4018, 4146, 4333, 4345, 4267, 96 4018, 4146, 4333, 4345, 4267,
98 ], 97 ],
99 'variables': { 98 'variables': {
100 'clang_warning_flags': [ 99 'clang_warning_flags': [
101 # TODO(thestig): Fix all instances, remove this, pdfium:29 100 # TODO(thestig): Fix all instances, remove this, pdfium:29
102 '-Wno-sign-compare', 101 '-Wno-sign-compare',
103 ], 102 ],
104 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux. 103 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
105 'cflags_cc!': [ '-Wsign-compare' ], 104 'cflags_cc!': [ '-Wsign-compare' ],
106 }, 105 },
107 }, 106 },
(...skipping 928 matching lines...) Expand 10 before | Expand all | Expand 10 after
1036 'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h', 1035 'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h',
1037 'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h', 1036 'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h',
1038 'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h', 1037 'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h',
1039 'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h', 1038 'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h',
1040 ], 1039 ],
1041 }, 1040 },
1042 ] 1041 ]
1043 }], 1042 }],
1044 ] 1043 ]
1045 } 1044 }
OLDNEW
« no previous file with comments | « core/fxcrt/include/fx_system.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698