Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1836403003: Remove static_cast in WorkerThreadTestHelper.h (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp1257343003_rebased
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove static_cast in WorkerThreadTestHelper.h BUG= Committed: https://crrev.com/9ce52bcb841b2875b6e482f60ac830f564901d54 Cr-Commit-Position: refs/heads/master@{#386354}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 3 chunks +34 lines, -41 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836403003/1
4 years, 8 months ago (2016-04-05 05:52:35 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/154299) ios_rel_device_gn on ...
4 years, 8 months ago (2016-04-05 05:54:45 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836403003/20001
4 years, 8 months ago (2016-04-11 06:25:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 07:36:43 UTC) #8
hiroshige
A little refactoring.
4 years, 8 months ago (2016-04-11 08:40:10 UTC) #10
kinuko
lgtm
4 years, 8 months ago (2016-04-11 08:46:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836403003/20001
4 years, 8 months ago (2016-04-11 09:03:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 09:09:03 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 09:10:24 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9ce52bcb841b2875b6e482f60ac830f564901d54
Cr-Commit-Position: refs/heads/master@{#386354}

Powered by Google App Engine
This is Rietveld 408576698