Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1836363002:
Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. (Closed)
|
Created:
4 years, 8 months ago by tapted Modified:
4 years, 8 months ago Reviewers:
erikchen CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@20160329-Mac-DeploymentTarget Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:].
The replacement is [NSNib instantiateWithOwner:..], which says:
Unlike legacy methods, the objects adhere to standard Cocoa memory
management rules; it is necessary to keep a strong reference to the
objects or the array to prevent the nib contents from being
deallocated."
That is, the deprecated method would put objects into the array with an
additional reference count "For historical reasons" (according to Apple's
"Nib Files" conceptual document). Chrome had a loop to remove this
additional reference, which is no longer required.
Chrome uses it in GetViewFromNib(..); used by content_shell and the save
file dialog accessory view. Tested these manually.
BUG=547071
Committed: https://crrev.com/868930a9584029000df4c195dbd6be71ee98c1da
Cr-Commit-Position: refs/heads/master@{#384080}
Patch Set 1 #Patch Set 2 : cl format #Patch Set 3 : Add forward declare #Messages
Total messages: 13 (8 generated)
Description was changed from ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:.., which says "Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ========== to ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:.., which says "Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ==========
tapted@chromium.org changed reviewers: + erikchen@chromium.org
Description was changed from ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:.., which says "Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ========== to ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:.., which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ==========
Description was changed from ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:.., which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ========== to ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ==========
Description was changed from ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apples "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ========== to ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apple's "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ==========
erikchen: PTAL
lgtm
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836363002/40001
Message was sent while issue was closed.
Description was changed from ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apple's "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ========== to ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apple's "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apple's "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 ========== to ========== Mac: Remove use of deprecated [NSNib instantiateNibWithOwner:topLevelObjects:]. The replacement is [NSNib instantiateWithOwner:..], which says: Unlike legacy methods, the objects adhere to standard Cocoa memory management rules; it is necessary to keep a strong reference to the objects or the array to prevent the nib contents from being deallocated." That is, the deprecated method would put objects into the array with an additional reference count "For historical reasons" (according to Apple's "Nib Files" conceptual document). Chrome had a loop to remove this additional reference, which is no longer required. Chrome uses it in GetViewFromNib(..); used by content_shell and the save file dialog accessory view. Tested these manually. BUG=547071 Committed: https://crrev.com/868930a9584029000df4c195dbd6be71ee98c1da Cr-Commit-Position: refs/heads/master@{#384080} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/868930a9584029000df4c195dbd6be71ee98c1da Cr-Commit-Position: refs/heads/master@{#384080} |
