Remove IFDE_XML* classes.

Remove IFDE_XML* classes.

The CFDE_XML* classes did not inhert from the IFDE_XML variants but we casted
to them anyway. This CL removes the IFDE_XML* variants and we just use the
CPDF_XML* classes directly.

BUG=pdfium:357
Committed: https://pdfium.googlesource.com/pdfium/+/ae95f763dfb5e4fab3a9ff026b2f844c202625d7

[dsinclair, 2016-03-29 20:32:03]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-03-29 20:32:04]

PTAL.

https://codereview.chromium.org/1836353002/diff/1/xfa/fde/xml/fde_xml_imp.h
File xfa/fde/xml/fde_xml_imp.h (right):

https://codereview.chromium.org/1836353002/diff/1/xfa/fde/xml/fde_xml_imp.h#n...
xfa/fde/xml/fde_xml_imp.h:206: class CFDE_XMLParser {
This was the only interface that actually had more then one implementation.
Moved it to a CFDE to be consistent with the rest of the XML_* calls.

[Tom Sepez, 2016-03-29 20:45:07]

https://codereview.chromium.org/1836353002/diff/20001/testing/libfuzzer/pdf_x...
File testing/libfuzzer/pdf_xml_fuzzer.cc (right):

https://codereview.chromium.org/1836353002/diff/20001/testing/libfuzzer/pdf_x...
testing/libfuzzer/pdf_xml_fuzzer.cc:58: if (!doc)
nit: new can't fail.

https://codereview.chromium.org/1836353002/diff/20001/testing/libfuzzer/pdf_x...
testing/libfuzzer/pdf_xml_fuzzer.cc:62: new CXFA_XMLParser(doc->GetRoot(),
stream.get()));
ditto

https://codereview.chromium.org/1836353002/diff/20001/xfa/fde/xml/fde_xml_imp.h
File xfa/fde/xml/fde_xml_imp.h (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fde/xml/fde_xml_imp...
xfa/fde/xml/fde_xml_imp.h:317: virtual void Release() { delete this; }
Nothing inherits to/from CFDE_XMLSyntaxParser, so these don't need to be
virtual.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
File xfa/fxfa/app/xfa_ffdochandler.h (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
xfa/fxfa/app/xfa_ffdochandler.h:25: virtual void GetPackageName(IXFA_Doc* hDoc,
Which of these are overrides, while we're at it.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
File xfa/fxfa/parser/xfa_document_datamerger_imp.cpp (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1267:
FXSYS_assert(pDatasetsXMLNode);
nit: new can't fail.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1311:
FXSYS_assert(pDataRootXMLNode);
ditto

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1359:
FXSYS_assert(pDataTopLevelXMLNode);
ditto

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:83: if (m_pXMLDoc == NULL) {
can't happen

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:130: if (m_pXMLDoc == NULL) {
can't happen.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:180:
static_cast<CFDE_XMLElement*>(pXMLChild)->GetLocalTagName(wsNodeStr);
nit: might read cleaner if we used a local to hold the result of the cast rather
than casting twice.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:1488: m_pParent =
(CFDE_XMLNode*)*m_NodeStack.GetTopElement();
nit: static cast.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.h (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.h:130: 
nit: no blank line here.

[dsinclair, 2016-03-29 20:58:47]

https://codereview.chromium.org/1836353002/diff/20001/testing/libfuzzer/pdf_x...
File testing/libfuzzer/pdf_xml_fuzzer.cc (right):

https://codereview.chromium.org/1836353002/diff/20001/testing/libfuzzer/pdf_x...
testing/libfuzzer/pdf_xml_fuzzer.cc:58: if (!doc)
On 2016/03/29 20:45:06, Tom Sepez wrote:
> nit: new can't fail.

Done.

https://codereview.chromium.org/1836353002/diff/20001/testing/libfuzzer/pdf_x...
testing/libfuzzer/pdf_xml_fuzzer.cc:62: new CXFA_XMLParser(doc->GetRoot(),
stream.get()));
On 2016/03/29 20:45:06, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fde/xml/fde_xml_imp.h
File xfa/fde/xml/fde_xml_imp.h (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fde/xml/fde_xml_imp...
xfa/fde/xml/fde_xml_imp.h:317: virtual void Release() { delete this; }
On 2016/03/29 20:45:06, Tom Sepez wrote:
> Nothing inherits to/from CFDE_XMLSyntaxParser, so these don't need to be
> virtual.

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
File xfa/fxfa/app/xfa_ffdochandler.h (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
xfa/fxfa/app/xfa_ffdochandler.h:25: virtual void GetPackageName(IXFA_Doc* hDoc,
On 2016/03/29 20:45:06, Tom Sepez wrote:
> Which of these are overrides, while we're at it.

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
File xfa/fxfa/parser/xfa_document_datamerger_imp.cpp (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1267:
FXSYS_assert(pDatasetsXMLNode);
On 2016/03/29 20:45:06, Tom Sepez wrote:
> nit: new can't fail.

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1311:
FXSYS_assert(pDataRootXMLNode);
On 2016/03/29 20:45:06, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:1359:
FXSYS_assert(pDataTopLevelXMLNode);
On 2016/03/29 20:45:06, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:83: if (m_pXMLDoc == NULL) {
On 2016/03/29 20:45:07, Tom Sepez wrote:
> can't happen

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:130: if (m_pXMLDoc == NULL) {
On 2016/03/29 20:45:07, Tom Sepez wrote:
> can't happen.

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:180:
static_cast<CFDE_XMLElement*>(pXMLChild)->GetLocalTagName(wsNodeStr);
On 2016/03/29 20:45:07, Tom Sepez wrote:
> nit: might read cleaner if we used a local to hold the result of the cast
rather
> than casting twice.

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:1488: m_pParent =
(CFDE_XMLNode*)*m_NodeStack.GetTopElement();
On 2016/03/29 20:45:07, Tom Sepez wrote:
> nit: static cast.

Done.

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.h (right):

https://codereview.chromium.org/1836353002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.h:130: 
On 2016/03/29 20:45:07, Tom Sepez wrote:
> nit: no blank line here.

Done.

[Tom Sepez, 2016-03-29 23:19:37]

lgtm

https://codereview.chromium.org/1836353002/diff/40001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1836353002/diff/40001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:84: 
nit: no blank line here.

https://codereview.chromium.org/1836353002/diff/40001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:126: 
nit: no blank line here.

[dsinclair, 2016-03-29 23:43:13]

https://codereview.chromium.org/1836353002/diff/40001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1836353002/diff/40001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:84: 
On 2016/03/29 23:19:37, Tom Sepez wrote:
> nit: no blank line here.

Done.

https://codereview.chromium.org/1836353002/diff/40001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:126: 
On 2016/03/29 23:19:37, Tom Sepez wrote:
> nit: no blank line here.

Done.

[dsinclair, 2016-03-29 23:43:27]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-03-29 23:43:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1836353002/#ps60001
(title: "")

[commit-bot: I haz the power, 2016-03-29 23:43:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1836353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1836353002/60001

[commit-bot: I haz the power, 2016-03-29 23:58:33]

Description was changed from

==========
Remove IFDE_XML* classes.

The CFDE_XML* classes did not inhert from the IFDE_XML variants but we casted
to them anyway. This CL removes the IFDE_XML* variants and we just use the
CPDF_XML* classes directly.

BUG=pdfium:357
==========

to

==========
Remove IFDE_XML* classes.

The CFDE_XML* classes did not inhert from the IFDE_XML variants but we casted
to them anyway. This CL removes the IFDE_XML* variants and we just use the
CPDF_XML* classes directly.

BUG=pdfium:357

Committed:
https://pdfium.googlesource.com/pdfium/+/ae95f763dfb5e4fab3a9ff026b2f844c2026...
==========

[commit-bot: I haz the power, 2016-03-29 23:58:34]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/ae95f763dfb5e4fab3a9ff026b2f844c2026...