Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: net/docs/bug-triage.md

Issue 1836343002: Tweak network doc wording, fix link, and make order in workflow match (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/docs/bug-triage-suggested-workflow.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Chrome Network Bug Triage 1 # Chrome Network Bug Triage
2 2
3 The Chrome network team uses a two day bug triage rotation. The main goals are 3 The Chrome network team uses a two day bug triage rotation. The main goals are
4 to identify and label new network bugs, and investigate network bugs when no 4 to identify and label new network bugs, and investigate network bugs when no
5 label seems suitable. 5 label seems suitable.
6 6
7 ## Responsibilities 7 ## Responsibilities
8 8
9 ### Required, in rough order of priority: 9 ### Required, in rough order of priority:
10 * Identify new network bugs on the tracker. 10 * Identify new network bugs on the tracker.
11 * Investigate UMA notifications. 11 * Investigate UMA notifications.
12 * Investigate recent Internals>Network issues with no subcomponent. 12 * Investigate recent Internals>Network issues with no subcomponent.
13 * Follow up on Needs-Feedback issues for all network components. 13 * Follow up on Needs-Feedback issues for all network components.
14 * Identify and file bugs for significant new crashers. 14 * Identify and file bugs for significant new crashers.
15 15
16 ### Best effort: 16 ### Best effort, also in rough priority order:
17 * Investigate unowned and owned-but-forgotten net/ crashers. 17 * Investigate unowned and owned-but-forgotten net/ crashers.
18 * Investigate old bugs. 18 * Investigate old bugs.
19 * Close obsolete bugs. 19 * Close obsolete bugs.
20 20
21 All of the above is to be done on each rotation. These responsibilities should 21 All of the above is to be done on each rotation. These responsibilities should
22 be tracked, and anything left undone at the end of a rotation should be handed 22 be tracked, and anything left undone at the end of a rotation should be handed
23 off to the next triager. The downside to passing along bug investigations like 23 off to the next triager. The downside to passing along bug investigations like
24 this is each new triager has to get back up to speed on bugs the previous 24 this is each new triager has to get back up to speed on bugs the previous
25 triager was investigating. The upside is that triagers don't get stuck 25 triager was investigating. The upside is that triagers don't get stuck
26 investigating issues after their time after their rotation, and it results in a 26 investigating issues after their time after their rotation, and it results in a
27 uniform, predictable two day commitment for all triagers. 27 uniform, predictable two day commitment for all triagers.
28 28
29 ## Details 29 ## Details
30 30
31 ### Required: 31 ### Required:
32 32
33 * Identify new network bugs on the bug tracker. All Unconfirmed issues filed 33 * Identify new network bugs on the bug tracker. All Unconfirmed issues filed
34 during your triage rotation should be scanned, and, for suspected network 34 during your triage rotation should be scanned, and, for suspected network
35 bugs, a network component assigned and an about:net-internals log requested. 35 bugs, a network component assigned and an about:net-internals log requested.
36 A triager is responsible for looking at bugs reported from noon PST / 3:00 pm 36 A triager is responsible for looking at bugs reported from noon PST / 3:00 pm
37 EST of the last day of the previous triager's rotation until the same time on 37 EST of the last day of the previous triager's rotation until the same time on
38 the last day of their rotation. Once you've changed labels on a bug, mark it 38 the last day of their rotation. Once you've assigned a bug to a component,
39 Untriaged, so other triagers sorting through Unconfirmed bugs won't see it. 39 mark it Untriaged, so other triagers sorting through Unconfirmed bugs won't
40 see it.
40 41
41 * For desktop bugs, ask for a net-internals log and give the user a link to 42 * For desktop bugs, ask for a net-internals log and give the user a link to
42 https://sites.google.com/a/chromium.org/dev/for-testers/providing-network- details 43 https://sites.google.com/a/chromium.org/dev/for-testers/providing-network- details
43 (A link there appears on about:net-internals, for easy reference) for 44 (A link there appears on about:net-internals, for easy reference) for
44 instructions. On mobile, point them to about:net-export. In either case, 45 instructions. On mobile, point them to about:net-export. In either case,
45 attach the Needs-Feedback label. 46 attach the Needs-Feedback label.
46 47
47 * Investigate UMA notifications. 48 * Investigate UMA notifications.
48 49
49 * UMA notifications ("chirps") are alerts based on UMA histograms that are 50 * UMA notifications ("chirps") are alerts based on UMA histograms that are
50 sent to chrome-network-debugging@google.com. Triagers should subscribe 51 sent to chrome-network-debugging@google.com. Triagers should subscribe
51 to this list. When an alert fires, the triager should determine if the 52 to this list. When an alert fires, the triager should determine if the
52 alert looks to be real and file a bug with the appropriate label if so. 53 alert looks to be real and file a bug with the appropriate label if so.
53 Note that if no label more specific than Internals>Network is appropriate, 54 Note that if no label more specific than Internals>Network is appropriate,
54 the responsibility remains with the triager to continue investigating the 55 the responsibility remains with the triager to continue investigating the
55 bug, as above. 56 bug, as above.
56 57
57 * The triager is responsible for looking at any notification previous 58 * The triager is responsible for looking at any notification previous
58 triagers did not, so when an issue is investigated, the person who did 59 triagers did not, so when an issue is investigated, the person who did
59 so should respond to chrome-network-debugging@google.com with a short 60 so should respond to chrome-network-debugging@google.com with a short
60 email, describing their conclusions. Future triagers can then use the 61 email, describing their conclusions. Future triagers can then use the
61 fact an alert was responded to as an inidicator of which of them need 62 fact an alert was responded to as an inidicator of which of them need
62 to be followed up on. 63 to be followed up on. Alerts fired before the beginning of the
64 previous triager's rotation may be ignored.
mmenke 2016/03/29 20:19:43 +"and passive-aggressively whine at the previous t
63 65
64 * Investigate [Uncomfirmed / Untriaged Internals>Network issues that don't belon g to a more specific network component](https://bugs.chromium.org/p/chromium/iss ues/list?can=2&q=component%3DInternals%3ENetwork+status%3AUnconfirmed,Untriaged+ -label:Needs-Feedback&sort=-modified), 66 * Investigate [Uncomfirmed / Untriaged Internals>Network issues that don't belon g to a more specific network component](https://bugs.chromium.org/p/chromium/iss ues/list?can=2&q=component%3DInternals%3ENetwork+status%3AUnconfirmed,Untriaged+ -label:Needs-Feedback&sort=-modified),
65 prioritizing the most recent issues, ones with the most responsive reporters, 67 prioritizing the most recent issues, ones with the most responsive reporters,
66 and major crashers. This will generally take up the majority of your time as 68 and major crashers. This will generally take up the majority of your time as
67 triager. Continue digging until you can do one of the following: 69 triager. Continue digging until you can do one of the following:
68 70
69 * Mark it as *WontFix* (working as intended, obsolete issue) or a 71 * Mark it as *WontFix* (working as intended, obsolete issue) or a
70 duplicate. 72 duplicate.
71 73
72 * Mark it as a feature request. 74 * Mark it as a feature request.
73 75
74 * Mark it as Needs-Feedback. 76 * Mark it as Needs-Feedback.
75 77
76 * Remove the Internals>Network component, replacing it with at least one 78 * Remove the Internals>Network component, replacing it with at least one
77 more specific network component or non-network component. Replacing the 79 more specific network component or non-network component. Replacing the
78 Internals>Network component gets it off the next triager's radar, and 80 Internals>Network component gets it off the next triager's radar, and
79 in front of someone more familiar with the relevant code. Note that 81 in front of someone more familiar with the relevant code. Note that
80 due to the way the bug report wizard works, a lot of bugs incorrectly end 82 due to the way the bug report wizard works, a lot of bugs incorrectly end
81 up with the network component. 83 up with the network component.
82 84
83 * The issue is assigned to an appropriate owner, and make sure to mark it 85 * The issue is assigned to an appropriate owner, and make sure to mark it
84 as "assigned" so the next triager doesn't run into it. 86 as "assigned" so the next triager doesn't run into it.
85 87
86 * If there is no more specific component for a bug, it should be 88 * If there is no more specific component for a bug, it should be
87 investigated by the triager until we have a good understanding of the 89 investigated by the triager until we have a good understanding of the
88 cause of the problem, and some idea how it should be fixed, at which point 90 cause of the problem, and some idea how it should be fixed, at which point
89 its status should be set to Available. Future triagers should ignore bugs 91 its status should be set to Available. Future triagers should ignore bugs
90 with this status, unless investigating stale bugs. 92 with this status, unless investigating stale bugs.
91 93
92 * Follow up on [Needs-Feedback issues for all components owned by the network st ack team](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component%3AI nternals%3ENetwork%2CUI>Browser>Downloads+-component%3AInternals%3ENetwork%3EDat aProxy+-component%3AInternals%3ENetwork%3EDataUse+-component%3AInternals%3ENetwo rk%3EVPN+Needs%3DFeedback&sort=-modified). 94 * Follow up on [Needs-Feedback issues for all components owned by the network st ack team](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component%3AI nternals%3ENetwork%2CUI%3EBrowser%3EDownloads+-component%3AInternals%3ENetwork%3 EDataProxy+-component%3AInternals%3ENetwork%3EDataUse+-component%3AInternals%3EN etwork%3EVPN+Needs%3DFeedback&sort=-modified).
mmenke 2016/03/29 20:19:43 Ahh...Was wondering why I missed one of the downlo
93 95
94 * Remove label once feedback is provided. Continue to investigate, if 96 * Remove label once feedback is provided. Continue to investigate, if
95 the previous section applies. 97 the previous section applies.
96 98
97 * If the Needs-Feedback label has been present for one week, ping the 99 * If the Needs-Feedback label has been present for one week, ping the
98 reporter. 100 reporter.
99 101
100 * Archive after two weeks with no feedback, telling users to file a new 102 * Archive after two weeks with no feedback, telling users to file a new
101 bug if they still have the issue, with the requested information, unless 103 bug if they still have the issue, with the requested information, unless
102 the reporter indicates they'll provide data when they can. In that case, 104 the reporter indicates they'll provide data when they can. In that case,
(...skipping 26 matching lines...) Expand all
129 * Close obsolete bugs. 131 * Close obsolete bugs.
130 132
131 See [bug-triage-suggested-workflow.md](bug-triage-suggested-workflow.md) for 133 See [bug-triage-suggested-workflow.md](bug-triage-suggested-workflow.md) for
132 suggested workflows. 134 suggested workflows.
133 135
134 See [bug-triage-labels.md](bug-triage-labels.md) for labeling tips for network 136 See [bug-triage-labels.md](bug-triage-labels.md) for labeling tips for network
135 and non-network bugs. 137 and non-network bugs.
136 138
137 See [crash-course-in-net-internals.md](crash-course-in-net-internals.md) for 139 See [crash-course-in-net-internals.md](crash-course-in-net-internals.md) for
138 some help on getting started with about:net-internals debugging. 140 some help on getting started with about:net-internals debugging.
OLDNEW
« no previous file with comments | « no previous file | net/docs/bug-triage-suggested-workflow.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698