Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py

Issue 1836293002: [Findit] Adding central config test class for unit tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py b/appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py
index 0978af793332859474c42c160f554a172cc28169..e82de912c8f332dded42c2885c8b3875fd6ad0c5 100644
--- a/appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py
+++ b/appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py
@@ -4,19 +4,17 @@
import os
-from testing_utils import testing
-
from common import chromium_deps
-from model.wf_analysis import WfAnalysis
from model import wf_analysis_status
+from model.wf_analysis import WfAnalysis
from pipeline_wrapper import pipeline_handlers
from waterfall import buildbot
-from waterfall.analyze_build_failure_pipeline import AnalyzeBuildFailurePipeline
from waterfall import lock_util
-from waterfall import waterfall_config
+from waterfall.analyze_build_failure_pipeline import AnalyzeBuildFailurePipeline
+from waterfall.test import wf_testcase
-class AnalyzeBuildFailurePipelineTest(testing.AppengineTestCase):
+class AnalyzeBuildFailurePipelineTest(wf_testcase.WaterfallTestCase):
app_module = pipeline_handlers._APP
def _MockChangeLog(
@@ -104,13 +102,6 @@ class AnalyzeBuildFailurePipelineTest(testing.AppengineTestCase):
self._Setup(master_name, builder_name, build_number)
- def MockStepIsSupportedForMaster(*_):
- return True
-
- self.mock(waterfall_config,
- 'StepIsSupportedForMaster',
- MockStepIsSupportedForMaster)
-
root_pipeline = AnalyzeBuildFailurePipeline(master_name,
builder_name,
build_number,

Powered by Google App Engine
This is Rietveld 408576698