Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Issue 1836293002: [Findit] Adding central config test class for unit tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
index e446360e1a71bf18a75c9dfed0fbbb1063a73ee0..5a2ac6075d9705df54e8ef814321020e6c0f5f8b 100644
--- a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
@@ -4,15 +4,14 @@
from datetime import datetime
import json
-from testing_utils import testing
import time
from common import buildbucket_client
from model import wf_analysis_status
from model.wf_try_job import WfTryJob
from model.wf_try_job_data import WfTryJobData
-from waterfall import waterfall_config
from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline
+from waterfall.test import wf_configured_test_case
from waterfall.try_job_type import TryJobType
@@ -24,7 +23,8 @@ REQUEST_COUNTER = {
}
-class MonitorTryJobPipelineTest(testing.AppengineTestCase):
+class MonitorTryJobPipelineTest(
+ wf_configured_test_case.WaterfallConfiguredTestCase):
def _MockGetTryJobs(self, build_id):
def Mocked_GetTryJobs(*_):
@@ -121,17 +121,8 @@ class MonitorTryJobPipelineTest(testing.AppengineTestCase):
self.mock(buildbucket_client, 'GetTryJobs', Mocked_GetTryJobs)
- def _MockGetTryJobSettings(self):
- return {
- 'server_query_interval_seconds': 60,
- 'job_timeout_hours': 5,
- 'allowed_response_error_times': 5
- }
-
def setUp(self):
super(MonitorTryJobPipelineTest, self).setUp()
- self.mock(
- waterfall_config, 'GetTryJobSettings', self._MockGetTryJobSettings)
self.mock(time, 'sleep', lambda x: None)
def testMicrosecondsToDatetime(self):
@@ -215,7 +206,6 @@ class MonitorTryJobPipelineTest(testing.AppengineTestCase):
try_job.status = wf_analysis_status.ANALYZING
try_job.put()
self._MockGetTryJobs(try_job_id)
- self._MockGetTryJobSettings()
pipeline = MonitorTryJobPipeline()
compile_result = pipeline.run(
@@ -262,7 +252,6 @@ class MonitorTryJobPipelineTest(testing.AppengineTestCase):
try_job.status = wf_analysis_status.ANALYZING
try_job.put()
self._MockGetTryJobs(try_job_id)
- self._MockGetTryJobSettings()
pipeline = MonitorTryJobPipeline()
test_result = pipeline.run(

Powered by Google App Engine
This is Rietveld 408576698