Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: appengine/findit/handlers/test/handlers_util_test.py

Issue 1836293002: [Findit] Adding central config test class for unit tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fixing code coverage Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/test/handlers_util_test.py
diff --git a/appengine/findit/handlers/test/handlers_util_test.py b/appengine/findit/handlers/test/handlers_util_test.py
index f0c6230339b779a0fb896fee14c9f4bc7ebdde75..606645c7c24a5ac7a9503df2ea0a1e3b5c16f66b 100644
--- a/appengine/findit/handlers/test/handlers_util_test.py
+++ b/appengine/findit/handlers/test/handlers_util_test.py
@@ -2,18 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-from testing_utils import testing
-
from handlers import handlers_util
from model.wf_analysis import WfAnalysis
from model import wf_analysis_status
+from model.test import configured_test_case
from model.wf_swarming_task import WfSwarmingTask
from model.wf_try_job import WfTryJob
-from waterfall import buildbot
-from waterfall import waterfall_config
-class HandlersUtilResultTest(testing.AppengineTestCase):
+class HandlersUtilResultTest(configured_test_case.ConfiguredTestCase):
def setUp(self):
super(HandlersUtilResultTest, self).setUp()
@@ -21,11 +18,6 @@ class HandlersUtilResultTest(testing.AppengineTestCase):
self.builder_name = 'b'
self.build_number = 121
- def MockedGetSwarmingSettings():
- return {'server_host': 'chromium-swarm.appspot.com'}
- self.mock(
- waterfall_config, 'GetSwarmingSettings', MockedGetSwarmingSettings)
-
def testGenerateSwarmingTasksDataNoAnalysis(self):
data = handlers_util.GenerateSwarmingTasksData(
self.master_name, self.builder_name, self.build_number)

Powered by Google App Engine
This is Rietveld 408576698