Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: appengine/findit/model/test/versioned_config_test.py

Issue 1836293002: [Findit] Adding central config test class for unit tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/test/versioned_config_test.py
diff --git a/appengine/findit/model/test/versioned_config_test.py b/appengine/findit/model/test/versioned_config_test.py
index a1d2b268a91a642f0f917552c6b3644b81731c65..ad1fb04f1f0ab407f7072bba735edea83fbb4b8c 100644
--- a/appengine/findit/model/test/versioned_config_test.py
+++ b/appengine/findit/model/test/versioned_config_test.py
@@ -3,7 +3,7 @@
# found in the LICENSE file.
from google.appengine.ext import ndb
-
+from google.appengine.api import users
from testing_utils import testing
from model.versioned_config import VersionedConfig
@@ -16,7 +16,8 @@ class _Config(VersionedConfig):
class VersionedConfigTest(testing.AppengineTestCase):
def _CreateFirstVersion(self):
config = _Config.Get()
- config.Update(a=1)
+ config.Update(user=users.User(email='admin@chromium.org'),
+ is_admin=True, a=1)
def testGetWhenNoConfigCreatedYet(self):
config = _Config.Get()
@@ -26,14 +27,16 @@ class VersionedConfigTest(testing.AppengineTestCase):
def testNonAdminCanNotUpdate(self):
config = _Config.Get()
with self.assertRaises(Exception):
- config.Update()
+ config.Update(user=users.User(email='admin@chromium.org'),
+ is_admin=False, a=1)
def testUpdateWhenChanged(self):
- self.mock_current_user(user_email='test@chromium.org', is_admin=True)
self._CreateFirstVersion()
config = _Config.Get()
self.assertIsNotNone(config)
- self.assertTrue(config.Update(a=2))
+ self.assertTrue(config.Update(
+ user=users.User(email='admin@chromium.org'), is_admin=True,
+ a=2))
config = _Config.Get()
self.assertIsNotNone(config)
@@ -41,11 +44,12 @@ class VersionedConfigTest(testing.AppengineTestCase):
self.assertEqual(2, config.a)
def testNotUpdateWhenNotChanged(self):
- self.mock_current_user(user_email='test@chromium.org', is_admin=True)
self._CreateFirstVersion()
config = _Config.Get()
self.assertIsNotNone(config)
- self.assertFalse(config.Update(a=1))
+ self.assertFalse(config.Update(
+ user=users.User(email='admin@chromium.org'), is_admin=True,
+ a=1))
config = _Config.Get()
self.assertIsNotNone(config)

Powered by Google App Engine
This is Rietveld 408576698