[Findit] Adding central config test class for unit tests

appengine/findit/model/versioned_config.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Versioned singleton entity with the global configuration."""
 
 import logging
 
 from google.appengine.api import users
 from google.appengine.ext import ndb
@@ skipping 12 matching lines @@
 
   # Who created this revision of configuration.
   updated_by = ndb.StringProperty(indexed=False)
 
   @classmethod
   def Get(cls, version=None):
     """Returns the version of the config entity, the latest if not specified."""
     config_data = cls.GetVersion(version)
     return config_data or cls() if version is None else config_data
 
-  def Update(self, **kwargs):
+  def Update(self, user=None, is_admin=False, **kwargs):
     """Applies |kwargs| dict to the entity and stores the entity if changed."""
-    if not users.is_current_user_admin():
+    if not user and not is_admin and not users.is_current_user_admin():

[stgao, 2016/04/01 23:35:48]

As we already pass in the user and is_admin, why we still need
users.is_current_user_admin() and users.get_current_user() below?

We'd better keep one code path instead of too.

[stgao, 2016/04/01 23:35:48]

bug: seems we should use 'or' instead of 'and' here.

[lijeffrey, 2016/04/04 21:35:05]

Done.

       raise Exception('Only admin could update config.')
 
     dirty = False
     for k, v in kwargs.iteritems():
       assert k in self._properties, k
       if getattr(self, k) != v:
         setattr(self, k, v)
         dirty = True
 
     if dirty:
-      user_name = users.get_current_user().email().split('@')[0]
+      current_user = user if user else users.get_current_user()
+      user_name = current_user.email().split('@')[0]
       self.updated_by = user_name
       self.Save()
       logging.info('Config %s was updated by %s', self.__class__, user_name)
 
     return dirty