[Findit] Adding central config test class for unit tests

appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 
-from testing_utils import testing
-
 from model import wf_analysis_status
 from model.wf_swarming_task import WfSwarmingTask
 from waterfall import process_swarming_task_result_pipeline
 from waterfall import swarming_util
-from waterfall import waterfall_config
 from waterfall.process_swarming_task_result_pipeline import (
     ProcessSwarmingTaskResultPipeline)
+from waterfall.test import wf_configured_test_case
 
 
 _ISOLATED_SERVER = 'https://isolateserver.appspot.com'
 _ISOLATED_STORAGE_URL = 'isolateserver.storage.googleapis.com'
 _SAMPLE_FAILURE_LOG = {
     'per_iteration_data': [
         {
             'TestSuite1.test1': [
                 {
                     'status': 'SUCCESS',
@@ skipping 73 matching lines @@
         'total_run': 6,
         'FAILURE': 6
     }
 }
 _EXPECTED_CLASSIFIED_TESTS = {
     'flaky_tests': ['TestSuite1.test2', 'TestSuite1.test1'],
     'reliable_tests': ['TestSuite1.test3']
 }
 
 
-_MOCK_SWARMING_SETTINGS = {
-    'task_timeout_hours': 23,
-    'server_query_interval_seconds': 60,
-    'iterations_to_rerun': 10,
-    'server_host': 'chromium-swarm.appspot.com',
-    'default_request_priority': 150,
-    'isolated_storage_url': 'isolateserver.storage.googleapis.com',
-    'isolated_server': 'https://isolateserver.appspot.com',
-    'request_expiration_hours': 20
-}
-
-
-class ProcessSwarmingTaskResultPipelineTest(testing.AppengineTestCase):
+class ProcessSwarmingTaskResultPipelineTest(
+    wf_configured_test_case.WaterfallConfiguredTestCase):
 
   def _MockedGetSwarmingTaskResultById(self, task_id, _):
     swarming_task_results = {
         'task_id1': {
             'state': 'COMPLETED',
             'tags': [
                 'priority:25',
                 'ref_name:abc_tests'
             ],
             'outputs_ref': {
@@ skipping 13 matching lines @@
 
     mocked_result = swarming_task_results[task_id]
     return mocked_result
 
   def setUp(self):
     super(ProcessSwarmingTaskResultPipelineTest, self).setUp()
     self.master_name = 'm'
     self.builder_name = 'b'
     self.build_number = 121
     self.step_name = 'abc_tests on platform'
-    def _MockGetSwarmingSettings():
-      return _MOCK_SWARMING_SETTINGS
-    self.mock(waterfall_config, 'GetSwarmingSettings', _MockGetSwarmingSettings)
     self.mock(swarming_util, 'GetSwarmingTaskResultById',
               self._MockedGetSwarmingTaskResultById)
 
   def testCheckTestsRunStatusesNoOutPutJson(self):
     tests_statuses = (
         process_swarming_task_result_pipeline._CheckTestsRunStatuses(None))
     self.assertEqual({}, tests_statuses)
 
   def testCheckTestsRunStatuses(self):
     tests_statuses = (
@@ skipping 29 matching lines @@
     self.assertEqual(wf_analysis_status.ANALYZED, task.status)
     self.assertEqual(_EXPECTED_TESTS_STATUESE, task.tests_statuses)
     self.assertEqual(_EXPECTED_CLASSIFIED_TESTS, task.classified_tests)
     self.assertEqual(datetime.datetime(2016, 2, 10, 18, 32, 6, 538220),
                      task.created_time)
     self.assertEqual(datetime.datetime(2016, 2, 10, 18, 32, 9, 90550),
                      task.started_time)
     self.assertEqual(datetime.datetime(2016, 2, 10, 18, 33, 9),
                      task.completed_time)
 
-
   def testProcessSwarmingTaskResultPipelineTaskNotRunning(self):
     task_id = 'task_id2'
 
     WfSwarmingTask.Create(
         self.master_name, self.builder_name,
         self.build_number, self.step_name).put()
 
     pipeline = ProcessSwarmingTaskResultPipeline()
     step_name, task_info = pipeline.run(
         self.master_name, self.builder_name,
         self.build_number, self.step_name, task_id)
 
     self.assertEqual(self.step_name, step_name)
     self.assertIsNone(task_info[0])
     self.assertEqual({}, task_info[1])
 
     task = WfSwarmingTask.Get(
         self.master_name, self.builder_name, self.build_number, self.step_name)
 
     self.assertEqual(wf_analysis_status.ERROR, task.status)
     self.assertEqual({}, task.tests_statuses)
     self.assertEqual({}, task.classified_tests)
 
   def testProcessSwarmingTaskResultPipelineTaskTimeOut(self):
     task_id = 'task_id1'
-    old_mock_timeout = _MOCK_SWARMING_SETTINGS['task_timeout_hours']
-    _MOCK_SWARMING_SETTINGS['task_timeout_hours'] = -1
+    config_settings = wf_configured_test_case.DEFAULT_UNIT_TEST_CONFIG_DATA

[stgao, 2016/03/31 18:07:13]

How about adding a func in wf_configured_test_case to do the config overwrite
the default values with new values like the one here?

+    config_settings['swarming_settings']['task_timeout_hours'] = -1
+    self.mock_current_user(user_email='test@chromium.org', is_admin=True)
+    wf_configured_test_case.MockConfigSettings(config_settings)
 
     WfSwarmingTask.Create(
         self.master_name, self.builder_name,
         self.build_number, self.step_name).put()
 
     pipeline = ProcessSwarmingTaskResultPipeline()
     step_name, task_info = pipeline.run(
         self.master_name, self.builder_name,
         self.build_number, self.step_name, task_id)
 
     self.assertEqual(self.step_name, step_name)
     self.assertEqual('abc_tests', task_info[0])
     self.assertEqual({}, task_info[1])
 
     task = WfSwarmingTask.Get(
         self.master_name, self.builder_name, self.build_number, self.step_name)
 
     self.assertEqual(wf_analysis_status.ERROR, task.status)
     self.assertEqual({}, task.tests_statuses)
     self.assertEqual({}, task.classified_tests)
-
-    _MOCK_SWARMING_SETTINGS['task_timeout_hours'] = old_mock_timeout
+    wf_configured_test_case.MockConfigSettings()

[stgao, 2016/03/31 18:07:13]

Why this one is needed? In each test run, the setUp will be called which means
that the config will be reset.

[lijeffrey, 2016/03/31 22:50:20]

Done.