[Findit] Adding central config test class for unit tests

appengine/findit/waterfall/test/try_job_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
-from testing_utils import testing
-
 from common import buildbucket_client
 from common.git_repository import GitRepository
 from model import wf_analysis_status
+from model.test import configured_test_case
 from model.wf_try_job import WfTryJob
 from pipeline_wrapper import pipeline_handlers
-from waterfall import waterfall_config
 from waterfall.try_job_pipeline import TryJobPipeline
 from waterfall.try_job_type import TryJobType
 
 
-class TryJobPipelineTest(testing.AppengineTestCase):
+class TryJobPipelineTest(configured_test_case.ConfiguredTestCase):
   app_module = pipeline_handlers._APP
 
-  def _MockGetTrybotForWaterfallBuilder(self, *_):
-    def MockedGetTrybotForWaterfallBuilder(*_):
-      return 'linux_chromium_variable', 'master.tryserver.chromium.linux'
-    self.mock(waterfall_config, 'GetTrybotForWaterfallBuilder',
-              MockedGetTrybotForWaterfallBuilder)
+  def setUp(self):
+    super(TryJobPipelineTest, self).setUp()

[stgao, 2016/03/30 01:06:30]

Could be removed too.

[lijeffrey, 2016/03/30 23:28:34]

Done.

 
   def _Mock_TriggerTryJobs(self, responses):
     def MockedTriggerTryJobs(*_):
       try_job_results = []
       for response in responses:
         if response.get('error'):  # pragma: no cover
           try_job_results.append((
               buildbucket_client.BuildbucketError(response['error']), None))
         else:
           try_job_results.append((
@@ skipping 48 matching lines @@
 
         def __init__(self, commit_position, code_review_url):
           self.commit_position = commit_position
           self.code_review_url = code_review_url
 
       mock_change_logs = {}
       mock_change_logs['rev2'] = MockedChangeLog('2', 'url_2')
       return mock_change_logs.get(revision)
     self.mock(GitRepository, 'GetChangeLog', MockedGetChangeLog)
 
-  def _MockGetTryJobSettings(self):
-    def _GetMockTryJobSettings():
-      return {
-          'server_query_interval_seconds': 60,
-          'job_timeout_hours': 5,
-          'allowed_response_error_times': 1
-      }
-    self.mock(waterfall_config, 'GetTryJobSettings', _GetMockTryJobSettings)
-
   def testSuccessfullyScheduleNewTryJobForCompile(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
 
     responses = [
         {
             'build': {
                 'id': '1',
                 'url': 'url',
                 'status': 'SCHEDULED',
             }
         }
     ]
-    self._MockGetTrybotForWaterfallBuilder(master_name, builder_name)
+
     self._Mock_TriggerTryJobs(responses)
     self._Mock_GetTryJobs('1')
     self._Mock_GetChangeLog('rev2')
-    self._MockGetTryJobSettings()
 
     WfTryJob.Create(master_name, builder_name, build_number).put()
 
     root_pipeline = TryJobPipeline(
         master_name, builder_name, build_number, 'rev1', 'rev2', ['rev2'],
         TryJobType.COMPILE, [])
     root_pipeline.start()
     self.execute_queued_tasks()
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
@@ skipping 43 matching lines @@
     build_number = 1
 
     root_pipeline = TryJobPipeline(
         master_name, builder_name, build_number, 'rev1', 'rev2', ['rev2'],
         TryJobType.COMPILE, [])
     root_pipeline._LogUnexpectedAbort(True)
 
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     self.assertIsNone(try_job)