[Findit] Adding central config test class for unit tests

appengine/findit/handlers/test/build_failure_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 
 from google.appengine.ext import testbed
 import webapp2
 import webtest
 
 from testing_utils import testing
 
 from handlers import build_failure
+from model import wf_analysis_status
+from model.test import configured_test_case
 from model.wf_analysis import WfAnalysis
-from model import wf_analysis_status
 from waterfall import buildbot
-from waterfall import waterfall_config
 
 
 # Root directory appengine/findit.
 ROOT_DIR = os.path.join(os.path.dirname(__file__),
                         os.path.pardir, os.path.pardir)
 
 
 class BuildFailureTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication([
       ('/build-failure', build_failure.BuildFailure),
@@ skipping 44 matching lines @@
                    re.MULTILINE | re.DOTALL),
         self.test_app.get, '/build-failure', params={'url': build_url})
 
   def testNonAdminCanViewAnalysisOfFailureOnUnsupportedMaster(self):
     master_name = 'm'
     builder_name = 'b 1'
     build_number = 123
     build_url = buildbot.CreateBuildUrl(
         master_name, builder_name, build_number)
 
-    def MockMasterIsSupported(*_):
-      return False
-    self.mock(waterfall_config, 'MasterIsSupported',
-              MockMasterIsSupported)
-
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.status = wf_analysis_status.ANALYZED
     analysis.put()
 
     response = self.test_app.get('/build-failure',
                                  params={'url': build_url})
     self.assertEquals(200, response.status_int)
     self.assertEqual(0, len(self.taskqueue_stub.get_filtered_tasks()))
 
   def testNonAdminCannotRequestAnalysisOfFailureOnUnsupportedMaster(self):
     master_name = 'm'
     builder_name = 'b 1'
     build_number = 123
     build_url = buildbot.CreateBuildUrl(
         master_name, builder_name, build_number)
 
-    def MockMasterIsSupported(*_):
-      return False
-    self.mock(waterfall_config, 'MasterIsSupported', MockMasterIsSupported)
-
     self.assertRaisesRegexp(
         webtest.app.AppError,
         re.compile('.*501 Not Implemented.*Master "%s" '
                    'is not supported yet.*' % master_name,
                    re.MULTILINE | re.DOTALL),
         self.test_app.get, '/build-failure', params={'url': build_url})
 
   def testAdminCanRequestAnalysisOfFailureOnUnsupportedMaster(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 123
     build_url = buildbot.CreateBuildUrl(
         master_name, builder_name, build_number)
 
-    def MockMasterIsSupported(*_):
-      return False
-    self.mock(waterfall_config, 'MasterIsSupported', MockMasterIsSupported)
-
     self.mock_current_user(user_email='test@chromium.org', is_admin=True)
 
     response = self.test_app.get('/build-failure', params={'url': build_url})
     self.assertEquals(200, response.status_int)
 
     self.assertEqual(1, len(self.taskqueue_stub.get_filtered_tasks()))
 
   def testAnyoneCanRequestAnalysisOfFailureOnSupportedMaster(self):
     master_name = 'm'
     builder_name = 'b 1'
     build_number = 123
     build_url = buildbot.CreateBuildUrl(
         master_name, builder_name, build_number)
-
-    def MockMasterIsSupported(*_):
-      return True
-    self.mock(waterfall_config, 'MasterIsSupported', MockMasterIsSupported)
+    self.mock_current_user(user_email='test@chromium.org', is_admin=True)
+    configured_test_case.MockConfigSettings()

[stgao, 2016/03/30 01:06:30]

Is it possible to make BuildFailureTest inherit from 
configured_test_case.WaterfallTestCase instead?

This seems more like a hack.

[lijeffrey, 2016/03/30 23:28:34]

Done.

+    self.mock_current_user(user_email='anyone@chromium.org', is_admin=False)
 
     response = self.test_app.get('/build-failure', params={'url': build_url})
     self.assertEquals(200, response.status_int)
 
     self.assertEqual(1, len(self.taskqueue_stub.get_filtered_tasks()))