[Findit] Adding central config test class for unit tests

appengine/findit/waterfall/test/build_failure_analysis_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 
-from testing_utils import testing
-
 from common.blame import Blame
 from common.blame import Region
 from common.change_log import FileChangeInfo
 from common.diff import ChangeType
 from common.git_repository import GitRepository
 from waterfall import build_failure_analysis
-from waterfall import waterfall_config
 from waterfall.failure_signal import FailureSignal
+from waterfall.test import wf_testcase
 
 
-class BuildFailureAnalysisTest(testing.AppengineTestCase):
+class BuildFailureAnalysisTest(wf_testcase.WaterfallTestCase):
 
   def _MockGetChangeLog(self, revision):
 
     class MockChangeLog(object):
 
       def __init__(self, date, touched_files):
         self.author_time = datetime.strptime(
             'Jun %s 04:35:32 2015' % date, '%b %d %H:%M:%S %Y')
         self.touched_files = touched_files
 
@@ skipping 519 matching lines @@
     failure_info = {
         'failed': True,
         'chromium_revision': None,
     }
     result = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs=None, deps_info=None, failure_signals=None)
     self.assertEqual(0, len(result['failures']))
 
   def testAnalyzeBuildFailure(self):
     failure_info = {
-        'master_name': 'blabla',
+        'master_name': 'm',
         'failed': True,
         'chromium_revision': 'r99_2',
         'failed_steps': {
             'a': {
                 'current_failure': 99,
                 'first_failure': 98,
             },
             'b': {
                 'current_failure': 99,
                 'first_failure': 98,
@@ skipping 121 matching lines @@
                         'score': 5,
                         'hints': {
                             'added x/y/f99_1.cc (and it was in log)': 5,
                         },
                     }
                 ],
             }
         ]
     }
 
-    def MockStepIsSupportedForMaster(*_):
-      return True
-    self.mock(waterfall_config, 'StepIsSupportedForMaster',
-              MockStepIsSupportedForMaster)
-
     analysis_result = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs, deps_info, failure_signals_json)
     self.assertEqual(expected_analysis_result, analysis_result)
 
   def testAnalyzeBuildFailureTestLevel(self):
     failure_info = {
         'failed': True,
         'chromium_revision': 'r99_2',
+        'master_name': 'm',
         'failed_steps': {
             'a': {
                 'current_failure': 99,
                 'first_failure': 98,
             },
             'b': {
                 'current_failure': 99,
                 'first_failure': 98,
                 'last_pass': 96,
                 'list_isolated_data': [
@@ skipping 124 matching lines @@
                 },
                 'Unittest3.Subtest2': {
                     'files': {
                         'y/z/f98.cc': [456],
                     },
                 }
             }
         }
     }
 
-    def MockStepIsSupportedForMaster(*_):
-      return True
-    self.mock(waterfall_config, 'StepIsSupportedForMaster',
-              MockStepIsSupportedForMaster)
-
     def MockGetChangedLines(repo_info, touched_file, line_numbers, _):
       # Only need line_numbers, ignoring the first two parameters.
       del repo_info, touched_file
       if line_numbers:
         return line_numbers
     self.mock(build_failure_analysis, '_GetChangedLinesForChromiumRepo',
               MockGetChangedLines)
 
     expected_analysis_result = {
         'failures': [
@@ skipping 113 matching lines @@
         ]
     }
 
     analysis_result = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs, deps_info, failure_signals_json)
 
     self.assertEqual(expected_analysis_result, analysis_result)
 
   def testAnalyzeBuildFailureForUnsupportedStep(self):
     failure_info = {
-        'master_name': 'm',
+        'master_name': 'master1',
         'failed': True,
         'chromium_revision': 'r99_2',
         'failed_steps': {
-            'not_supported': {
+            'unsupported_step1': {
                 'current_failure': 99,
                 'first_failure': 98,
             },
         },
         'builds': {
             '99': {
                 'blame_list': ['r99_1', 'r99_2'],
             },
             '98': {
                 'blame_list': ['r98_1'],
             },
         }
     }
     change_logs = {}
     deps_info = {}
     failure_signals_json = {
         'not_supported': {
             'files': {
                 'src/a/b/f99_2.cc': [],
             },
         }
     }
     expected_analysis_result = {
         'failures': [
             {
-                'step_name': 'not_supported',
+                'step_name': 'unsupported_step1',
                 'supported': False,
                 'first_failure': 98,
                 'last_pass': None,
                 'suspected_cls': [],
             },
         ]
     }
 
-    def MockStepIsSupportedForMaster(*_):
-      return False
-    self.mock(waterfall_config, 'StepIsSupportedForMaster',
-              MockStepIsSupportedForMaster)
-
     analysis_result = build_failure_analysis.AnalyzeBuildFailure(
         failure_info, change_logs, deps_info, failure_signals_json)
     self.assertEqual(expected_analysis_result, analysis_result)
 
   def testGetGitBlame(self):
     repo_info = {
         'repo_url': 'https://chromium.googlesource.com/chromium/src.git',
         'revision': '8'
     }
     file_path = 'a/b/c.cc'
@@ skipping 107 matching lines @@
         touched_file, file_path_in_log, justification, file_name_occurrences,
         line_numbers, repo_info, commit_revision)
 
     expected_justification = {
         'score': 4,
         'hints': {
             'modified c.cc[1, 3] (and it was in log)': 4
         }
     }
     self.assertEqual(expected_justification, justification.ToDict())