[Findit] Adding central config test class for unit tests

appengine/findit/waterfall/test/wf_testcase.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.api import users
+from testing_utils import testing
+
+import copy
+
+from model.wf_config import FinditConfig
+
+
+_DEFAULT_STEPS_FOR_MASTERS_RULES = {
+    'supported_masters': {
+        'm': {
+            'check_global': True
+        },
+        'm3': {
+            'check_global': True
+        },
+        'master1': {
+            # supported_steps override global.
+            'supported_steps': ['unsupported_step6'],
+            'unsupported_steps': ['unsupported_step1',
+                                  'unsupported_step2',
+                                  'unsupported_step3'],
+            'check_global': True
+        },
+        'master2': {
+            # Only supports step4 and step5 regardless of global.
+            'supported_steps': ['step4', 'step5'],
+            'check_global': False
+        },
+        'master3': {
+            # Supports everything not blacklisted in global.
+            'check_global': True
+        },
+    },
+    'global': {
+        # Blacklists all listed steps for all masters unless overridden.
+        'unsupported_steps': ['unsupported_step6', 'unsupported_step7'],
+    }
+}
+
+
+_DEFAULT_TRY_BOT_MAPPING = {
+    'master1': {
+        'builder1': {
+            'mastername': 'tryserver1',
+            'buildername': 'trybot1',
+            'strict_regex': True,
+        }
+    },
+    'm': {
+        'b': {
+            'mastername': 'tryserver.master',
+            'buildername': 'tryserver.builder',
+        }
+    }
+}
+
+
+_DEFAULT_TRY_JOB_SETTINGS = {
+    'server_query_interval_seconds': 60,
+    'job_timeout_hours': 5,
+    'allowed_response_error_times': 5
+}
+
+
+_DEFAULT_SWARMING_SETTINGS = {
+    'server_host': 'chromium-swarm.appspot.com',
+    'default_request_priority': 150,
+    'request_expiration_hours': 20,
+    'server_query_interval_seconds': 60,
+    'task_timeout_hours': 23,
+    'isolated_server': 'https://isolateserver.appspot.com',
+    'isolated_storage_url': 'isolateserver.storage.googleapis.com',
+    'iterations_to_rerun': 10
+}
+
+
+DEFAULT_CONFIG_DATA = {
+    'steps_for_masters_rules': _DEFAULT_STEPS_FOR_MASTERS_RULES,
+    'builders_to_trybots': _DEFAULT_TRY_BOT_MAPPING,
+    'try_job_settings': _DEFAULT_TRY_JOB_SETTINGS,
+    'swarming_settings': _DEFAULT_SWARMING_SETTINGS
+}
+
+
+class WaterfallTestCase(testing.AppengineTestCase):  # pragma: no cover.
+
+  def UpdateUnitTestConfigSettings(self, config_property=None,
+                                   override_data=None):

[stgao, 2016/04/05 00:13:47]

How about just one parameter ``override_config_data``? To be explicit, the code
looks like this:

config_data = copy.deepcopy(DEFAULT_CONFIG_DATA)
config_data.update(override_config_data)

[lijeffrey, 2016/04/05 00:57:19]

It seems if config_data is more than 1 layer deep (which it is for
steps_to_masters_rules, calling update will overwrite values.

For example,

config_data = {'a': {'b' : 1, 'c': 2}}
config_data.update({'a': {'d': 3}})
 
config_data
{'a': {'d': 3}}

and 'b' and 'c' are lost.

It does work however if calling config_data['a'].update({'d': 3})
config_data
{'a': {'c': 2, 'b': 1, 'd': 3}}

So in our case config_data.update({'swarming_settings': 'task_timeout_hours':
-1}) will cause other swarming_settings to be lost

[stgao, 2016/04/05 01:15:29]

ok. We could keep the current implemented approach.

If we want later, the alternative is to write a customized update function to do
the recursive update.

+    """Sets up Findit's config for unit tests.
+
+    Args:
+      config_property: The name of the config property to update.
+      override_data: A dict to override any default settings.
+    """
+    config_data = DEFAULT_CONFIG_DATA
+
+    if config_property and override_data:
+      config_data = copy.deepcopy(DEFAULT_CONFIG_DATA)
+      config_data[config_property].update(override_data)
+
+    FinditConfig.Get().Update(users.User(email='admin@chromium.org'), True,
+                              **config_data)
+
+  def setUp(self):
+    super(WaterfallTestCase, self).setUp()
+    self.UpdateUnitTestConfigSettings()
+
+