[Findit] Adding central config test class for unit tests

appengine/findit/handlers/config.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Handles requests to the findit config page."""
 
 import json
 
 from base_handler import BaseHandler
 from base_handler import Permission
 from model import wf_config
 from waterfall import waterfall_config
 
+from google.appengine.api import users
+
 
 def _RemoveDuplicatesAndSort(elements):
   return list(set(elements))
 
 
 def _IsListOfType(elements, element_type):
   """Determines whether or not elements is a list of unique elements of type."""
   if not elements or not isinstance(elements, list):
     return False
 
@@ skipping 212 matching lines @@
 
     return {'template': 'config.html', 'data': data}
 
   def HandlePost(self):
     data = self.request.params.get('data')
     new_config_dict = json.loads(data)
     if not _ConfigurationDictIsValid(new_config_dict):  # pragma: no cover
       return self.CreateError(
           'New configuration settings is not properly formatted.', 400)
 
-    wf_config.FinditConfig.Get().Update(**new_config_dict)
+    wf_config.FinditConfig.Get().Update(users.get_current_user(),
+                                        users.IsCurrentUserAdmin(),

[stgao, 2016/04/04 22:07:23]

nit: Inconsistent with API. is_admin is a key-value arg, while user is a
positional arg.

The testing code seems to have different calling style too.

[lijeffrey, 2016/04/04 23:56:41]

Done.

+                                        **new_config_dict)
 
     return self.HandleGet()