Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1836213004: [NTP Popular Sites] Bump default version to 5 (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Popular Sites] Bump default version to 5 BUG=none Committed: https://crrev.com/d763a95dee6d13b8bae544a8d59ab1016f22feb3 Cr-Commit-Position: refs/heads/master@{#384013}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/ntp/popular_sites.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Marc Treib
4 years, 8 months ago (2016-03-30 16:12:13 UTC) #2
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-03-30 16:15:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836213004/1
4 years, 8 months ago (2016-03-30 16:18:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/11033) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-03-30 16:20:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836213004/20001
4 years, 8 months ago (2016-03-30 16:24:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 17:11:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 17:12:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d763a95dee6d13b8bae544a8d59ab1016f22feb3
Cr-Commit-Position: refs/heads/master@{#384013}

Powered by Google App Engine
This is Rietveld 408576698