Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 18362: Experimental: statically distinguish between named basic block entries... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: statically distinguish between named basic block entries that are definitely reached by only forward CFG edges and those that may be reached by a backward edge. Assert that we do not try to jump backward to forward-only blocks. Otherwise, the two types of blocks are not handled differently yet. There are only a handful of backward edges: * one for each of the loop types (while, for, and do...while), * the for...in statement, * a loop in GenerateFastCharCodeAt, * the fall-through from a default case in a switch when it is not the last case, * (possibly) the return sequence * the exit labels from deferred code The last two are not true backward edges (there is no loop). Committed: http://code.google.com/p/v8/source/detail?r=1121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -25 lines) Patch
M src/codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codegen-ia32.cc View 11 chunks +17 lines, -12 lines 0 comments Download
M src/jump-target.h View 3 chunks +14 lines, -5 lines 0 comments Download
M src/jump-target-ia32.cc View 6 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The default argument actually seems more explicit, because the backward edges stand out more when ...
11 years, 11 months ago (2009-01-20 12:04:49 UTC) #1
William Hesse
11 years, 11 months ago (2009-01-21 07:59:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698