Remove vestigial legacy const handling from parser

Remove vestigial legacy const handling from parser

R=littledan@chromium.org

Committed: https://crrev.com/a63185a608e5583391cbc4518a55aabfc3ffb58d
Cr-Commit-Position: refs/heads/master@{#35459}

[adamk, 2016-04-14 00:04:05]

Ping?

[Dan Ehrenberg, 2016-04-14 00:13:22]

lgtm

[caitp (gmail), 2016-04-14 00:17:29]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2016-04-14 00:17:30]

https://codereview.chromium.org/1836183002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1836183002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2362: if (parsing_result->descriptor.mode == LET) {
This is not really the job of this CL, but this looks wrong, there shouldn't be
an implicit initializer for a let variable. Maybe a TODO() is in order?

[caitp (gmail), 2016-04-14 00:25:16]

https://codereview.chromium.org/1836183002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1836183002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2362: if (parsing_result->descriptor.mode == LET) {
On 2016/04/14 00:17:30, caitp wrote:
> This is not really the job of this CL, but this looks wrong, there shouldn't
be
> an implicit initializer for a let variable. Maybe a TODO() is in order?

eh, other vendors seem to behave the same, did the spec change? I thought these
were hole-y until assigned

[adamk, 2016-04-14 00:37:24]

https://codereview.chromium.org/1836183002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1836183002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2362: if (parsing_result->descriptor.mode == LET) {
On 2016/04/14 00:25:16, caitp wrote:
> On 2016/04/14 00:17:30, caitp wrote:
> > This is not really the job of this CL, but this looks wrong, there shouldn't
> be
> > an implicit initializer for a let variable. Maybe a TODO() is in order?
> 
> eh, other vendors seem to behave the same, did the spec change? I thought
these
> were hole-y until assigned

Nope, nothing recent here. Let variables are hole-initialized when we enter the
scope (to throw TDZ errors as appropriate), and then undefined-initialized then
we reach the declaration. I would believe this changed during the genesis of
ES6, but this is definitely what the spec says now :)

[adamk, 2016-04-14 00:38:39]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-04-14 00:38:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1836183002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-04-14 00:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1836183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1836183002/20001

[commit-bot: I haz the power, 2016-04-14 01:00:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 01:02:59]

Description was changed from

==========
Remove vestigial legacy const handling from parser

R=littledan@chromium.org
==========

to

==========
Remove vestigial legacy const handling from parser

R=littledan@chromium.org

Committed: https://crrev.com/a63185a608e5583391cbc4518a55aabfc3ffb58d
Cr-Commit-Position: refs/heads/master@{#35459}
==========

[commit-bot: I haz the power, 2016-04-14 01:03:00]

Patchset 2 (id:??) landed as
https://crrev.com/a63185a608e5583391cbc4518a55aabfc3ffb58d
Cr-Commit-Position: refs/heads/master@{#35459}