Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1836143003: Dirty mipmaps whenever we upload new contents for a texture. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Dirty mipmaps whenever we upload new contents for a texture. Found a bug where we rendered with two identically sized textures. On the first frame, everything worked. On subsequent frames, we would get the other texture from the cache, causing us to inherit the mips from the wrong texture. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1836143003 Committed: https://skia.googlesource.com/skia/+/3ebd2760dd34da6f5af23e9c7cb1b6a61e9cea9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Brian Osman
4 years, 8 months ago (2016-03-29 14:21:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836143003/1
4 years, 8 months ago (2016-03-29 14:21:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 14:31:37 UTC) #7
Brian Osman
Does this look okay?
4 years, 8 months ago (2016-03-29 17:15:03 UTC) #8
bsalomon
On 2016/03/29 17:15:03, Brian Osman wrote: > Does this look okay? lgtm, sorry forgot to ...
4 years, 8 months ago (2016-03-29 18:16:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836143003/1
4 years, 8 months ago (2016-03-29 18:26:25 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 18:27:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3ebd2760dd34da6f5af23e9c7cb1b6a61e9cea9d

Powered by Google App Engine
This is Rietveld 408576698