Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/accessibility/hit_testing_browsertest.cc

Issue 1836113002: Fix accessible touch exploration inside of iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test startup on Android Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/hit_testing_browsertest.cc
diff --git a/content/browser/accessibility/hit_testing_browsertest.cc b/content/browser/accessibility/hit_testing_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7610f73da1d0d12e36482484e48c803ea4fd2412
--- /dev/null
+++ b/content/browser/accessibility/hit_testing_browsertest.cc
@@ -0,0 +1,171 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <set>
+#include <string>
+#include <vector>
+
+#include "base/command_line.h"
+#include "base/files/file_util.h"
+#include "base/logging.h"
+#include "base/strings/string16.h"
+#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "content/browser/accessibility/accessibility_tree_formatter.h"
+#include "content/browser/accessibility/browser_accessibility.h"
+#include "content/browser/accessibility/browser_accessibility_manager.h"
+#include "content/browser/web_contents/web_contents_impl.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/common/content_paths.h"
+#include "content/public/common/content_switches.h"
+#include "content/public/common/url_constants.h"
+#include "content/public/test/content_browser_test.h"
+#include "content/public/test/content_browser_test_utils.h"
+#include "content/shell/browser/shell.h"
+#include "content/test/accessibility_browser_test_utils.h"
+#include "net/dns/mock_host_resolver.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace content {
+
+namespace {
+
+bool AXTreeContainsNodeWithName(BrowserAccessibility* node,
+ const std::string& name) {
+ if (node->GetStringAttribute(ui::AX_ATTR_NAME) == name)
+ return true;
+
+ for (unsigned i = 0; i < node->PlatformChildCount(); i++) {
+ if (AXTreeContainsNodeWithName(node->PlatformGetChild(i), name))
+ return true;
+ }
+
+ return false;
+}
+
+} // namespace
+
+class AccessibilityHitTestingBrowserTest : public ContentBrowserTest {
+ public:
+ AccessibilityHitTestingBrowserTest() {}
+ ~AccessibilityHitTestingBrowserTest() override {}
+
+ protected:
+ BrowserAccessibility* HitTestAndWaitForResult(const gfx::Point& point) {
+ WebContentsImpl* web_contents =
+ static_cast<WebContentsImpl*>(shell()->web_contents());
+ FrameTree* frame_tree = web_contents->GetFrameTree();
+ BrowserAccessibilityManager* manager =
+ web_contents->GetRootBrowserAccessibilityManager();
+
+ AccessibilityNotificationWaiter hover_waiter(
+ shell(), AccessibilityModeComplete, ui::AX_EVENT_HOVER);
+ for (FrameTreeNode* node : frame_tree->Nodes())
+ hover_waiter.ListenToAdditionalFrame(node->current_frame_host());
+ manager->delegate()->AccessibilityHitTest(point);
+ hover_waiter.WaitForNotification();
+
+ RenderFrameHostImpl* target_frame = hover_waiter.event_render_frame_host();
+ BrowserAccessibilityManager* target_manager =
+ target_frame->browser_accessibility_manager();
+ int hover_target_id = hover_waiter.event_target_id();
+ BrowserAccessibility* hovered_node =
+ target_manager->GetFromID(hover_target_id);
+ return hovered_node;
+ }
+};
+
+IN_PROC_BROWSER_TEST_F(AccessibilityHitTestingBrowserTest,
+ HitTestOutsideDocumentBoundsReturnsRoot) {
+ NavigateToURL(shell(), GURL(url::kAboutBlankURL));
+
+ // Load the page.
+ AccessibilityNotificationWaiter waiter(shell(), AccessibilityModeComplete,
+ ui::AX_EVENT_LOAD_COMPLETE);
+ const char url_str[] =
+ "data:text/html,"
+ "<!doctype html>"
+ "<html><head><title>Accessibility Test</title></head>"
+ "<body>"
+ "<a href='#'>"
+ "This is some text in a link"
+ "</a>"
+ "</body></html>";
+ GURL url(url_str);
+ NavigateToURL(shell(), url);
+ waiter.WaitForNotification();
+
+ BrowserAccessibility* hovered_node =
+ HitTestAndWaitForResult(gfx::Point(-1, -1));
+ ASSERT_TRUE(hovered_node != NULL);
+ ASSERT_EQ(ui::AX_ROLE_ROOT_WEB_AREA, hovered_node->GetRole());
+}
+
+IN_PROC_BROWSER_TEST_F(AccessibilityHitTestingBrowserTest,
+ HitTestingInIframes) {
+ host_resolver()->AddRule("*", "127.0.0.1");
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ NavigateToURL(shell(), GURL(url::kAboutBlankURL));
+
+ AccessibilityNotificationWaiter waiter(shell(), AccessibilityModeComplete,
+ ui::AX_EVENT_LOAD_COMPLETE);
+ GURL url(embedded_test_server()->GetURL(
+ "/accessibility/html/iframe-coordinates.html"));
+ NavigateToURL(shell(), url);
+ waiter.WaitForNotification();
+
+ WebContentsImpl* web_contents =
+ static_cast<WebContentsImpl*>(shell()->web_contents());
+ FrameTree* frame_tree = web_contents->GetFrameTree();
+ BrowserAccessibilityManager* manager =
+ web_contents->GetRootBrowserAccessibilityManager();
+ BrowserAccessibility* root = manager->GetRoot();
+ while (!AXTreeContainsNodeWithName(root, "Ordinary Button") ||
+ !AXTreeContainsNodeWithName(root, "Scrolled Button")) {
+ AccessibilityNotificationWaiter waiter(shell(), AccessibilityModeComplete,
+ ui::AX_EVENT_NONE);
+ for (FrameTreeNode* node : frame_tree->Nodes())
+ waiter.ListenToAdditionalFrame(node->current_frame_host());
+ waiter.WaitForNotification();
+ }
+
+ // Send a series of hit test requests, and for each one
+ // wait for the hover event in response, verifying we hit the
+ // correct object.
+
+ // (50, 50) -> "Button"
+ BrowserAccessibility* hovered_node;
+ hovered_node = HitTestAndWaitForResult(gfx::Point(50, 50));
+ ASSERT_TRUE(hovered_node != NULL);
+ ASSERT_EQ(ui::AX_ROLE_BUTTON, hovered_node->GetRole());
+ ASSERT_EQ("Button", hovered_node->GetStringAttribute(ui::AX_ATTR_NAME));
+
+ // (50, 305) -> div in first iframe
+ hovered_node = HitTestAndWaitForResult(gfx::Point(50, 305));
+ ASSERT_TRUE(hovered_node != NULL);
+ ASSERT_EQ(ui::AX_ROLE_DIV, hovered_node->GetRole());
+
+ // (50, 350) -> "Ordinary Button"
+ hovered_node = HitTestAndWaitForResult(gfx::Point(50, 350));
+ ASSERT_TRUE(hovered_node != NULL);
+ ASSERT_EQ(ui::AX_ROLE_BUTTON, hovered_node->GetRole());
+ ASSERT_EQ("Ordinary Button",
+ hovered_node->GetStringAttribute(ui::AX_ATTR_NAME));
+
+ // (50, 455) -> "Scrolled Button"
+ hovered_node = HitTestAndWaitForResult(gfx::Point(50, 455));
+ ASSERT_TRUE(hovered_node != NULL);
+ ASSERT_EQ(ui::AX_ROLE_BUTTON, hovered_node->GetRole());
+ ASSERT_EQ("Scrolled Button",
+ hovered_node->GetStringAttribute(ui::AX_ATTR_NAME));
+
+ // (50, 505) -> div in second iframe
+ hovered_node = HitTestAndWaitForResult(gfx::Point(50, 505));
+ ASSERT_TRUE(hovered_node != NULL);
+ ASSERT_EQ(ui::AX_ROLE_DIV, hovered_node->GetRole());
+}
+
+} // namespace content
« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698