Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: content/test/accessibility_browser_test_utils.cc

Issue 1836113002: Fix accessible touch exploration inside of iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make test server url relative Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/accessibility_browser_test_utils.cc
diff --git a/content/test/accessibility_browser_test_utils.cc b/content/test/accessibility_browser_test_utils.cc
index d44439bbe4e3da91409ef46954ed5c2f35f1ff18..ae822c9a871fca495e8522a98e0f3bae763c2dbd 100644
--- a/content/test/accessibility_browser_test_utils.cc
+++ b/content/test/accessibility_browser_test_utils.cc
@@ -24,6 +24,7 @@ AccessibilityNotificationWaiter::AccessibilityNotificationWaiter(Shell* shell)
: event_to_wait_for_(ui::AX_EVENT_NONE),
loop_runner_(new MessageLoopRunner()),
event_target_id_(0),
+ event_render_frame_host_(nullptr),
weak_factory_(this) {
WebContents* web_contents = shell->web_contents();
frame_host_ = static_cast<RenderFrameHostImpl*>(
@@ -91,10 +92,11 @@ const ui::AXTree& AccessibilityNotificationWaiter::GetAXTree() const {
}
void AccessibilityNotificationWaiter::OnAccessibilityEvent(
- ui::AXEvent event_type, int event_target_id) {
+ RenderFrameHostImpl* rfhi, ui::AXEvent event_type, int event_target_id) {
nasko 2016/03/30 21:01:41 style: Each parameter should be on a new line. git
dmazzoni 2016/03/31 16:15:55 Ran git cl format.
if (!IsAboutBlank() && (event_to_wait_for_ == ui::AX_EVENT_NONE ||
- event_to_wait_for_ == event_type)) {
+ event_to_wait_for_ == event_type)) {
event_target_id_ = event_target_id;
+ event_render_frame_host_ = rfhi;
loop_runner_->Quit();
}
}

Powered by Google App Engine
This is Rietveld 408576698