Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1836113002: Fix accessible touch exploration inside of iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make test server url relative Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index e982660a8a5b0a44e669ff5ea94555b00fa36481..eab5ad427375ee1af243167a7b18b117eee8f13d 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -547,6 +547,8 @@ bool RenderFrameHostImpl::OnMessageReceived(const IPC::Message &msg) {
OnAccessibilityLocationChanges)
IPC_MESSAGE_HANDLER(AccessibilityHostMsg_FindInPageResult,
OnAccessibilityFindInPageResult)
+ IPC_MESSAGE_HANDLER(AccessibilityHostMsg_ChildFrameHitTestResult,
+ OnAccessibilityChildFrameHitTestResult)
IPC_MESSAGE_HANDLER(AccessibilityHostMsg_SnapshotResponse,
OnAccessibilitySnapshotResponse)
IPC_MESSAGE_HANDLER(FrameHostMsg_ToggleFullscreen, OnToggleFullscreen)
@@ -1693,7 +1695,7 @@ void RenderFrameHostImpl::OnAccessibilityEvents(
CHECK(ax_tree_for_testing_->Unserialize(detail.update))
<< ax_tree_for_testing_->error();
}
- accessibility_testing_callback_.Run(detail.event_type, detail.id);
+ accessibility_testing_callback_.Run(this, detail.event_type, detail.id);
}
}
}
@@ -1735,6 +1737,14 @@ void RenderFrameHostImpl::OnAccessibilityFindInPageResult(
}
}
+void RenderFrameHostImpl::OnAccessibilityChildFrameHitTestResult(
+ const gfx::Point& point, int hit_obj_id) {
nasko 2016/03/30 21:01:41 style: Each param on a new line.
dmazzoni 2016/03/31 16:15:54 Done.
+ if (browser_accessibility_manager_) {
+ browser_accessibility_manager_->OnChildFrameHitTestResult(
+ point, hit_obj_id);
+ }
+}
+
void RenderFrameHostImpl::OnAccessibilitySnapshotResponse(
int callback_id,
const AXContentTreeUpdate& snapshot) {
@@ -2402,7 +2412,9 @@ void RenderFrameHostImpl::RequestAXTreeSnapshot(
}
void RenderFrameHostImpl::SetAccessibilityCallbackForTesting(
- const base::Callback<void(ui::AXEvent, int)>& callback) {
+ const base::Callback<void(RenderFrameHostImpl*,
+ ui::AXEvent,
+ int)>& callback) {
accessibility_testing_callback_ = callback;
}

Powered by Google App Engine
This is Rietveld 408576698