Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 1836113002: Fix accessible touch exploration inside of iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test startup on Android Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/accessibility_browser_test_utils.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 if (obj->style()->hasAppearance()) 1105 if (obj->style()->hasAppearance())
1106 LayoutTheme::theme().addVisualOverflow(*obj, r); 1106 LayoutTheme::theme().addVisualOverflow(*obj, r);
1107 result.unite(r); 1107 result.unite(r);
1108 } 1108 }
1109 } 1109 }
1110 return result; 1110 return result;
1111 } 1111 }
1112 1112
1113 AXObject* AXObject::elementAccessibilityHitTest(const IntPoint& point) const 1113 AXObject* AXObject::elementAccessibilityHitTest(const IntPoint& point) const
1114 { 1114 {
1115 // Check if there are any mock elements or child frames that need to be hand led. 1115 // Check if there are any mock elements that need to be handled.
1116 for (const auto& child : m_children) { 1116 for (const auto& child : m_children) {
1117 if (child->isMockObject() && child->elementRect().contains(point)) 1117 if (child->isMockObject() && child->elementRect().contains(point))
1118 return child->elementAccessibilityHitTest(point); 1118 return child->elementAccessibilityHitTest(point);
1119
1120 if (child->isWebArea()) {
1121 FrameView* frameView = child->documentFrameView();
1122 if (frameView)
1123 return child->accessibilityHitTest(IntPoint(point - frameView->f rameRect().location()));
1124 }
1125 } 1119 }
1126 1120
1127 return const_cast<AXObject*>(this); 1121 return const_cast<AXObject*>(this);
1128 } 1122 }
1129 1123
1130 const AXObject::AXObjectVector& AXObject::children() 1124 const AXObject::AXObjectVector& AXObject::children()
1131 { 1125 {
1132 updateChildrenIfNecessary(); 1126 updateChildrenIfNecessary();
1133 1127
1134 return m_children; 1128 return m_children;
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
1690 1684
1691 DEFINE_TRACE(AXObject) 1685 DEFINE_TRACE(AXObject)
1692 { 1686 {
1693 visitor->trace(m_children); 1687 visitor->trace(m_children);
1694 visitor->trace(m_parent); 1688 visitor->trace(m_parent);
1695 visitor->trace(m_cachedLiveRegionRoot); 1689 visitor->trace(m_cachedLiveRegionRoot);
1696 visitor->trace(m_axObjectCache); 1690 visitor->trace(m_axObjectCache);
1697 } 1691 }
1698 1692
1699 } // namespace blink 1693 } // namespace blink
OLDNEW
« no previous file with comments | « content/test/accessibility_browser_test_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698