Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: ui/views/examples/examples.gyp

Issue 1836093004: Fix base dependency in views_examples_with_content_exe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/examples/examples.gyp
diff --git a/ui/views/examples/examples.gyp b/ui/views/examples/examples.gyp
index c01bac2a422b4100a45466ef3236257598747af6..50790ad639aaeb3e26eed1439a38d04173408a6d 100644
--- a/ui/views/examples/examples.gyp
+++ b/ui/views/examples/examples.gyp
@@ -161,8 +161,6 @@
'target_name': 'views_examples_with_content_exe',
'type': 'executable',
'dependencies': [
- '../../../base/base.gyp:base',
- '../../../content/content.gyp:content',
'../../views_content_client/views_content_client.gyp:views_content_client',
'views_examples_with_content_lib',
],
@@ -171,6 +169,12 @@
'examples_with_content_main_exe.cc',
],
'conditions': [
+ ['component=="shared_library"', {
+ 'dependencies': [
+ '../../../base/base.gyp:base',
tfarina 2016/03/31 18:46:14 Are there other places where this is being doing l
Will Harris 2016/03/31 19:24:44 I agree it's quite mysterious, it doesn't happen i
tfarina 2016/03/31 19:53:43 I think gn does that only if the "library" is a so
+ '../../../content/content.gyp:content',
+ ],
+ }],
['OS=="win"', {
'link_settings': {
'libraries': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698