Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1836073003: media: Use "public_configs" for "mojo_media_config" (Closed)

Created:
4 years, 8 months ago by xhwang
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Use "public_configs" for "mojo_media_config" This reverts commit 220c7edc3243b54970a13d91c690b2dffc15732d and replace it with a better fix using public_configs. BUG=521731 Committed: https://crrev.com/90cf4b90efa19bebe97882a5b0ac317852515c29 Cr-Commit-Position: refs/heads/master@{#383633}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/renderer/BUILD.gn View 1 2 chunks +8 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xhwang
brettw: PTAL dalecurtis: FYI https://chromiumcodereview.appspot.com/1836073003/diff/1/content/renderer/BUILD.gn File content/renderer/BUILD.gn (right): https://chromiumcodereview.appspot.com/1836073003/diff/1/content/renderer/BUILD.gn#newcode265 content/renderer/BUILD.gn:265: public_configs = [ "//media/mojo/services:mojo_media_config" ] ...
4 years, 8 months ago (2016-03-28 21:34:33 UTC) #2
xhwang
Please review PS2 which removed some unnecessary change in PS1.
4 years, 8 months ago (2016-03-28 21:37:00 UTC) #3
brettw
LGTM, thanks!
4 years, 8 months ago (2016-03-28 22:24:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836073003/20001
4 years, 8 months ago (2016-03-28 23:32:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 00:35:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:36:34 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/90cf4b90efa19bebe97882a5b0ac317852515c29
Cr-Commit-Position: refs/heads/master@{#383633}

Powered by Google App Engine
This is Rietveld 408576698