Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1836013004: [heap] Added fine grained timers to MC_MARK_WEAK_CLOSURE. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Added fine grained timers to MC_MARK_WEAK_CLOSURE. BUG= Committed: https://crrev.com/3b1578db0c96a686d9db3bd189afd299ccc3e9a3 Cr-Commit-Position: refs/heads/master@{#35107}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M src/heap/gc-tracer.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 2 chunks +26 lines, -6 lines 0 comments Download
M tools/eval_gc_time.sh View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Hannes Payer (out of office)
4 years, 8 months ago (2016-03-29 12:24:53 UTC) #2
Michael Lippautz
dbc: Don't forget the script in tools/ :)
4 years, 8 months ago (2016-03-29 12:25:42 UTC) #4
ulan
lgtm with a comment. https://codereview.chromium.org/1836013004/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1836013004/diff/40001/src/heap/mark-compact.cc#newcode2183 src/heap/mark-compact.cc:2183: GCTracer::Scope::MC_MARK_WEAK_CLOSURE_EPHEMERAL_HARMONY); Let's name it MC_MARK_WEAK_CLOSURE_HARMONY ...
4 years, 8 months ago (2016-03-29 12:43:58 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1836013004/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1836013004/diff/40001/src/heap/mark-compact.cc#newcode2183 src/heap/mark-compact.cc:2183: GCTracer::Scope::MC_MARK_WEAK_CLOSURE_EPHEMERAL_HARMONY); On 2016/03/29 12:43:57, ulan wrote: > Let's name ...
4 years, 8 months ago (2016-03-29 12:52:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836013004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836013004/60001
4 years, 8 months ago (2016-03-29 12:52:39 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-03-29 14:51:40 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 14:52:30 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3b1578db0c96a686d9db3bd189afd299ccc3e9a3
Cr-Commit-Position: refs/heads/master@{#35107}

Powered by Google App Engine
This is Rietveld 408576698