Chromium Code Reviews| Index: chrome/tools/build/win/create_installer_archive.py |
| diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py |
| index 4c1694564c7288afaac84d55f664d708f707c4ed..7f465bddd73bd4c0b0ef6816a13d97e5b1866263 100755 |
| --- a/chrome/tools/build/win/create_installer_archive.py |
| +++ b/chrome/tools/build/win/create_installer_archive.py |
| @@ -505,6 +505,17 @@ def DoComponentBuildTasks(staging_dir, build_dir, target_arch, current_version): |
| 'msvc*.dll', |
| 'api-ms-win-*.dll', |
| 'vcruntime*.dll' ] |
| + if options.component_build == '1': |
|
brettw
2016/03/28 18:29:16
My brief reading of this function implies that thi
|
| + # The use of source sets in gn builds means that references to some extra |
| + # DLLs get pulled in to setup.exe. Unpacking these to |installer_dir| is |
| + # simpler and more robust than switching setup.exe to use libraries instead |
| + # of source sets. |
| + setup_component_dll_globs += [ 'ipc.dll', |
| + 'net.dll', |
| + 'prefs.dll', |
| + 'protobuf_lite.dll', |
| + 'url_lib.dll', |
| + 'base_i18n.dll' ] |
| for setup_component_dll_glob in setup_component_dll_globs: |
| setup_component_dlls = glob.glob(os.path.join(build_dir, |
| setup_component_dll_glob)) |