Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1835943005: Move mac_find_sdk out of gyp directory (Closed)

Created:
4 years, 8 months ago by Wei Li
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move mac_find_sdk out of gyp directory Gyp directory is used by a separate repository. Files in that directory may be ignored by some commands. Move it back into pdfium repository. BUG=pdfium:442 Committed: https://pdfium.googlesource.com/pdfium/+/a123f0184894073a8495bc0cf49b5c890781b289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
D build/gyp/tools/mac_find_sdk.py View 1 chunk +0 lines, -93 lines 0 comments Download
A + build/mac_find_sdk.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Wei Li
PTAL, thanks
4 years, 8 months ago (2016-03-30 00:36:58 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-03-30 17:22:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835943005/1
4 years, 8 months ago (2016-03-30 21:07:44 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 21:18:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1835943005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1835943005/1
4 years, 8 months ago (2016-03-30 21:23:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 21:24:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a123f0184894073a8495bc0cf49b5c890781...

Powered by Google App Engine
This is Rietveld 408576698