Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: tools/gn/visual_studio_writer.h

Issue 1835943002: GN: VS project calls ninja for single file compiles as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.h
diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h
index 297189606ecd66e1bcc3da83e5ae85c8e87886c5..99c537075fffbeebfa9c0543c231a1e8d2e48da2 100644
--- a/tools/gn/visual_studio_writer.h
+++ b/tools/gn/visual_studio_writer.h
@@ -21,6 +21,7 @@ class FilePath;
class Builder;
class BuildSettings;
class Err;
+class SourceFile;
class Target;
class VisualStudioWriter {
@@ -78,8 +79,19 @@ class VisualStudioWriter {
std::string config_platform;
};
+ struct SourceFileCompileTypePair {
+ SourceFileCompileTypePair(const SourceFile* file, const char* compile_type);
+ ~SourceFileCompileTypePair();
+
+ // Source file.
+ const SourceFile* file;
+ // Compile type string.
+ const char* compile_type;
+ };
+
using SolutionProjects = std::vector<std::unique_ptr<SolutionProject>>;
using SolutionFolders = std::vector<std::unique_ptr<SolutionEntry>>;
+ using SourceFileCompileTypePairs = std::vector<SourceFileCompileTypePair>;
VisualStudioWriter(const BuildSettings* build_settings,
const char* config_platform,
@@ -90,8 +102,11 @@ class VisualStudioWriter {
bool WriteProjectFileContents(std::ostream& out,
const SolutionProject& solution_project,
const Target* target,
+ SourceFileCompileTypePairs* source_types,
Err* err);
- void WriteFiltersFileContents(std::ostream& out, const Target* target);
+ void WriteFiltersFileContents(std::ostream& out,
+ const Target* target,
+ const SourceFileCompileTypePairs& source_types);
bool WriteSolutionFile(const std::string& sln_name, Err* err);
void WriteSolutionFileContents(std::ostream& out,
const base::FilePath& solution_dir_path);
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698